feat(anta.tests): Added testcase to verify vxlan1 source interface and udp port #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaheshGSLAB
commented
Feb 6, 2024
anta/custom_types.py
Outdated
| @@ -85,6 +85,12 @@ def bgp_multiprotocol_capabilities_abbreviations(value: str) -> str: | |||
| BeforeValidator(interface_autocomplete), | |||
| BeforeValidator(interface_case_sensitivity), | |||
| ] | |||
| VxlanSrcIntf = Annotated[ | |||
| str, | |||
| Field(pattern=r"^(Loopback)[0-9]+$"), | |||
There was a problem hiding this comment.
As loopback support 0-8191 so need to update the patter.
There was a problem hiding this comment.
Yes and please move this to the test itself. I doubt it will be used elsewhere.
There was a problem hiding this comment.
Oh never mind! I saw you added extra validators.
There was a problem hiding this comment.
Updated the custom type. Please take a look once.
@carl-baillargeon
anta/custom_types.py
Outdated
| @@ -85,6 +85,12 @@ def bgp_multiprotocol_capabilities_abbreviations(value: str) -> str: | |||
| BeforeValidator(interface_autocomplete), | |||
| BeforeValidator(interface_case_sensitivity), | |||
| ] | |||
| VxlanSrcIntf = Annotated[ | |||
| str, | |||
| Field(pattern=r"^(Loopback)[0-9]+$"), | |||
There was a problem hiding this comment.
Yes and please move this to the test itself. I doubt it will be used elsewhere.
anta/custom_types.py
Outdated
| @@ -85,6 +85,12 @@ def bgp_multiprotocol_capabilities_abbreviations(value: str) -> str: | |||
| BeforeValidator(interface_autocomplete), | |||
| BeforeValidator(interface_case_sensitivity), | |||
| ] | |||
| VxlanSrcIntf = Annotated[ | |||
| str, | |||
| Field(pattern=r"^(Loopback)[0-9]+$"), | |||
There was a problem hiding this comment.
Oh never mind! I saw you added extra validators.
anta/tests/vxlan.py
Outdated
|
|
||
| class VerifyVxlan1ConnSettings(AntaTest): | ||
| """ | ||
| Verifies the VXLAN source interface and UDP port. |
There was a problem hiding this comment.
Suggested change
| Verifies the VXLAN source interface and UDP port. | |
| Verifies the interface vxlan1 source interface and UDP port. |
anta/tests/vxlan.py
Outdated
| Verifies the VXLAN source interface and UDP port. | ||
|
|
||
| Expected Results: | ||
| * success: Passes if VXLAN source interface and UDP port are correct. |
There was a problem hiding this comment.
Suggested change
| * success: Passes if VXLAN source interface and UDP port are correct. | |
| * success: Passes if the interface vxlan1 source interface and UDP port are correct. |
anta/tests/vxlan.py
Outdated
|
|
||
| Expected Results: | ||
| * success: Passes if VXLAN source interface and UDP port are correct. | ||
| * failure: Fails if VXLAN source interface or UDP port are incorrect. |
There was a problem hiding this comment.
Suggested change
| * failure: Fails if VXLAN source interface or UDP port are incorrect. | |
| * failure: Fails if the interface vxlan1 source interface or UDP port are incorrect. |
anta/tests/vxlan.py
Outdated
| """ | ||
|
|
||
| name = "VerifyVxlan1ConnSettings" | ||
| description = "Verifies the VXLAN source interface and UDP port" |
There was a problem hiding this comment.
Suggested change
| description = "Verifies the VXLAN source interface and UDP port" | |
| description = "Verifies the interface vxlan1 source interface and UDP port." |
anta/tests/vxlan.py
Outdated
| source_interface: VxlanSrcIntf | ||
| """Source loopback interface of vxlan1 interface""" | ||
| udp_port: int = Field(ge=1024, le=65335) | ||
| """UDP port used for vxlan interface""" |
There was a problem hiding this comment.
Suggested change
| """UDP port used for vxlan interface""" | |
| """UDP port used for vxlan1 interface""" |
carl-baillargeon
requested changes
Feb 14, 2024
anta/custom_types.py
Outdated
| @@ -23,16 +23,20 @@ def interface_autocomplete(v: str) -> str: | |||
|
|
|||
| Supported alias: | |||
| - `et`, `eth` will be changed to `Ethernet` | |||
| - `po` will be changed to `Port-Channel`""" | |||
| - `po` will be changed to `Port-Channel` | |||
| - `lo`, `lb` will be changed to `Loopback`""" | |||
There was a problem hiding this comment.
lb is not a valid EOS syntax:
DC1-LEAF1A(config-if-Et1)#int lb 0
% Invalid input
DC1-LEAF1A(config-if-Et1)#int lb0
% Invalid input
DC1-LEAF1A(config-if-Et1)#
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added testcase to verify vxlan1 source interface and udp port.
Fixes #553
Verifies the VXLAN source interface and UDP port.
Checklist:
pre-commit run)tox -e testenv)