Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(anta.tests): use json outformat in VerifyInterfaceUtilization #580

Merged
merged 11 commits into from
Mar 12, 2024
Merged

fix(anta.tests): use json outformat in VerifyInterfaceUtilization #580

merged 11 commits into from
Mar 12, 2024

Conversation

mtache
Copy link
Collaborator

@mtache mtache commented Mar 12, 2024 •
edited
Loading

  • fix(anta.tests): use json outformat in VerifyInterfaceUtilization
  • test(anta.tests): update VerifyInterfaceUtilization unit tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@mtache @carl-baillargeon
Update anta/tests/interfaces.py
e7a736f 
Co-authored-by: Carl Baillargeon <carl.baillargeon@arista.com>
carl-baillargeon
carl-baillargeon approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI passes!

@mtache mtache merged commit c4737be into aristanetworks:main Mar 12, 2024
19 checks passed
@mtache mtache deleted the fix-interface-utilization branch March 12, 2024 15:33
@gmuloc gmuloc mentioned this pull request Apr 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc left review comments

@carl-baillargeon carl-baillargeon carl-baillargeon approved these changes

Assignees

@mtache mtache

Labels
rn: fix(anta.tests)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mtache @gmuloc @carl-baillargeon