Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(anta.tests): Fix an issue in VerifyL2MTU to capture interface name #581

Merged
merged 2 commits into from
Mar 12, 2024
Merged

fix(anta.tests): Fix an issue in VerifyL2MTU to capture interface name #581

merged 2 commits into from
Mar 12, 2024

Conversation

titom73
Copy link
Collaborator

@titom73 titom73 commented Mar 12, 2024 •
edited by mtache
Loading

Description

Fix an issue where interface name like Ethernet1/1 or Port-Channel1 were not caught by the test reporting VerifyL2MTU

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@titom73 titom73 added bug Something isn't working network-tests labels Mar 12, 2024
carl-baillargeon
carl-baillargeon approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@titom73 titom73 marked this pull request as draft March 12, 2024 16:49
@titom73 titom73 marked this pull request as ready for review March 12, 2024 17:24
@titom73 titom73 merged commit 0b35520 into aristanetworks:main Mar 12, 2024
19 checks passed
@gmuloc gmuloc mentioned this pull request Apr 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carl-baillargeon carl-baillargeon carl-baillargeon approved these changes

Assignees

@titom73 titom73

Labels
bug Something isn't working network-tests rn: fix(anta.tests)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@titom73 @carl-baillargeon