Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(anta.tests): Added 'cEOSCloudLab' in skip decorator #595

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

MaheshGSLAB
Copy link
Contributor

@MaheshGSLAB MaheshGSLAB commented Mar 20, 2024

Description

Added 'cEOSCloudLab' in skip decorator.

Fixes #560

  1. VerifyFieldNotice44Resolution: Command(show version detail) is supported but its verify Aboot version per FN0044 which is not needed for cEOSCloudLab.
  2. VerifyFieldNotice72Resolution: Command(show version detail) is supported but its verify the device is exposed to FN0072, and if the issue has been mitigated which is not needed for cEOSCloudLab.
  3. VerifyTransceiversManufacturers: No xcvrSlots for cEOSCloudLab device.
  4. VerifyTemperature: No need to check temp for cEOSCloudLab device.
  5. VerifyTransceiversTemperature: No need to check temp for cEOSCloudLab device.
  6. VerifyEnvironmentSystemCooling: No need to check cooling for cEOSCloudLab device.
  7. VerifyEnvironmentCooling: No need to check cooling of power and fan slots for cEOSCloudLab device.
  8. VerifyEnvironmentPower: No Need to check power state for cEOSCloudLab device.
  9. VerifyAdverseDrops: No need to check adverse drops for cEOSCloudLab device.
  10. VerifyStormControlDrops: @carl-baillargeon need your input here. Not made any change right now.
  11. VerifyPortChannels: @carl-baillargeon i think we dont need to skip this test for VM devices as command supports and gives proper output.
  12. VerifyLANZ: Command not support
  13. VerifyUnifiedForwardingTableMode: @carl-baillargeon I think command is depricated as current command is invalid(show platform trident forwarding-table partition)
  14. VerifyTcamProfile: @carl-baillargeon need your input here.
  15. VerifyPtpModeStatus: command not supported
  16. VerifyPtpGMStatus: command not supported.
  17. VerifyPtpLockStatus: command not supported.
  18. VerifyPtpOffset: command not supported.
  19. VerifyPtpPortModeStatus: command not supported.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@MaheshGSLAB MaheshGSLAB marked this pull request as ready for review March 21, 2024 06:15
Copy link
Collaborator

@titom73 titom73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carl-baillargeon carl-baillargeon merged commit 1a16cdf into aristanetworks:main Mar 21, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hardware test failed for module cEOSCloudLab
3 participants