Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(anta.tests): Added testcases for AVT feature #621

Merged
merged 13 commits into from
Apr 29, 2024
Merged

feat(anta.tests): Added testcases for AVT feature #621

merged 13 commits into from
Apr 29, 2024

Conversation

MaheshGSLAB
Copy link
Contributor

Description

Added the test cases for AVT features.

Fixes #615

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@MaheshGSLAB MaheshGSLAB marked this pull request as ready for review April 4, 2024 09:14
@gmuloc gmuloc added this to the v1.0.0 milestone Apr 12, 2024
gmuloc
gmuloc reviewed Apr 22, 2024
View reviewed changes
mkdocs.yml Outdated Show resolved Hide resolved
gmuloc
gmuloc reviewed Apr 22, 2024
View reviewed changes
docs/api/tests.md Outdated Show resolved Hide resolved
@gmuloc gmuloc added the on-hold Waiting for additional elements label Apr 22, 2024
gmuloc
gmuloc requested changes Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking merge until some JSON output issue is resolved on EOS side

@gmuloc
Copy link
Collaborator

gmuloc commented Apr 22, 2024

@MaheshGSLAB can you move the faiing test with ping avt in another PR and we will merge the 3 others?

@MaheshGSLAB MaheshGSLAB requested a review from gmuloc April 23, 2024 08:39
@gmuloc gmuloc removed the on-hold Waiting for additional elements label Apr 23, 2024
@MaheshGSLAB MaheshGSLAB requested a review from gmuloc April 25, 2024 11:02
gmuloc
gmuloc reviewed Apr 25, 2024
View reviewed changes
anta/tests/avt.py Outdated Show resolved Hide resolved
gmuloc
gmuloc reviewed Apr 26, 2024
View reviewed changes
anta/tests/avt.py Outdated Show resolved Hide resolved
anta/tests/avt.py Outdated Show resolved Hide resolved
anta/tests/avt.py Outdated Show resolved Hide resolved
anta/tests/avt.py Outdated Show resolved Hide resolved
anta/tests/avt.py Outdated Show resolved Hide resolved
@MaheshGSLAB MaheshGSLAB requested a review from gmuloc April 26, 2024 13:37
@gmuloc gmuloc merged commit 2e5a90b into aristanetworks:main Apr 29, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc approved these changes

@carl-baillargeon carl-baillargeon Awaiting requested review from carl-baillargeon

Assignees

@MaheshGSLAB MaheshGSLAB

Labels
network-tests rn: feat(anta.tests)
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

Add support to validate Adaptive virtual topology path
2 participants
@MaheshGSLAB @gmuloc