Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(anta.tests): ZeroDivisionError in VerifyInterfaceUtilization #626

Merged
merged 5 commits into from
Apr 12, 2024
Merged

fix(anta.tests): ZeroDivisionError in VerifyInterfaceUtilization #626

merged 5 commits into from
Apr 12, 2024

Conversation

mtache
Copy link
Collaborator

@mtache mtache commented Apr 12, 2024 •
edited
Loading

  • feat: now show Python module name at DEBUG log level
  • fix(anta.tests): fix ZeroDivisionError in VerifyInterfaceUtilization

Description

Fixes #603

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@mtache mtache linked an issue Apr 12, 2024 that may be closed by this pull request
Fix: Exception raised for test VerifyInterfaceUtilization: ZeroDivisionError: float division by zero #603
Closed
@mtache mtache changed the title fix: ZeroDivisionError in VerifyInterfaceUtilization fix(anta.tests): ZeroDivisionError in VerifyInterfaceUtilization Apr 12, 2024
@mtache mtache requested a review from gmuloc April 12, 2024 13:39
gmuloc
gmuloc reviewed Apr 12, 2024
View reviewed changes
anta/tests/interfaces.py Outdated Show resolved Hide resolved
gmuloc
gmuloc approved these changes Apr 12, 2024
View reviewed changes
Copy link
Collaborator

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@gmuloc gmuloc merged commit 245c6f9 into aristanetworks:main Apr 12, 2024
17 checks passed
@gmuloc gmuloc mentioned this pull request Apr 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc approved these changes

Assignees

@mtache mtache

Labels
rn: fix(anta.tests)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix: Exception raised for test VerifyInterfaceUtilization: ZeroDivisionError: float division by zero
2 participants
@mtache @gmuloc