Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add feature to search config #634

Merged
merged 2 commits into from
Apr 19, 2024
Merged

feat: Add feature to search config #634

merged 2 commits into from
Apr 19, 2024

Conversation

chetryan
Copy link
Contributor

Description

Add an Anta Test to search the running configuration for a list of regular expressions.

Fixes #632

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@chetryan chetryan changed the title Feat(anta): Add feature to search config feat: Add feature to search config Apr 18, 2024
gmuloc
gmuloc approved these changes Apr 19, 2024
View reviewed changes
Copy link
Collaborator

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @chetryan

@gmuloc
Copy link
Collaborator

gmuloc commented Apr 19, 2024

Uploading Screenshot 2024-04-19 at 10.31.20.png…

carl-baillargeon
carl-baillargeon approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@carl-baillargeon carl-baillargeon merged commit c87e62c into aristanetworks:main Apr 19, 2024
17 checks passed
@mtache mtache mentioned this pull request Jul 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc approved these changes

@carl-baillargeon carl-baillargeon carl-baillargeon approved these changes

Assignees

@chetryan chetryan

Labels
rn: feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Add support for generic checks in running config.
3 participants
@chetryan @gmuloc @carl-baillargeon