Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(anta): Optimize device to tests creation in ANTA runner #648

Merged
merged 21 commits into from
Apr 25, 2024

Conversation

carl-baillargeon
Copy link
Contributor

Description

Refactor ANTA runner to use indexes for tags for faster execution. Also moved some of the logic outside of the main function for clarity and manageability.

Updated unit tests.

Fixes # (issue id)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@gmuloc gmuloc added this to the v1.0.0 milestone Apr 23, 2024
anta/catalog.py Outdated Show resolved Hide resolved
anta/catalog.py Outdated Show resolved Hide resolved
anta/catalog.py Outdated Show resolved Hide resolved
anta/catalog.py Show resolved Hide resolved
anta/runner.py Show resolved Hide resolved
anta/runner.py Show resolved Hide resolved
anta/runner.py Outdated Show resolved Hide resolved
anta/runner.py Outdated Show resolved Hide resolved
anta/runner.py Outdated Show resolved Hide resolved
tests/units/test_catalog.py Show resolved Hide resolved
@gmuloc gmuloc changed the title fix(anta): Refactor ANTA runner fix(anta): Optimize (a lot) (test, device) tuples creation in ANTA runner Apr 23, 2024
anta/runner.py Outdated Show resolved Hide resolved
@carl-baillargeon carl-baillargeon changed the title fix(anta): Optimize (a lot) (test, device) tuples creation in ANTA runner fix(anta): Optimize device to tests creation in ANTA runner Apr 23, 2024
@gmuloc gmuloc merged commit 3fceb4d into aristanetworks:main Apr 25, 2024
17 checks passed
@carl-baillargeon carl-baillargeon deleted the refactor/runner branch May 18, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants