Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(anta): Add dry-run mode for NRFU #650

Merged
merged 8 commits into from
Apr 25, 2024
Merged

feat(anta): Add dry-run mode for NRFU #650

merged 8 commits into from
Apr 25, 2024

Conversation

gmuloc
Copy link
Collaborator

@gmuloc gmuloc commented Apr 24, 2024 •
edited
Loading

Description

  • Add a --dry-run option for nrfu to avoid communicating with the network
  • part of the troubleshooting perf effort

Checklist:

TODO

  • Add tests
  • Add doc

Repo

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@gmuloc gmuloc mentioned this pull request Apr 24, 2024
Merged
6 tasks
@mtache mtache merged commit 15af88d into aristanetworks:main Apr 25, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtache mtache mtache approved these changes

Assignees

@gmuloc gmuloc

Labels
rn: feat(anta)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gmuloc @mtache