Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(anta.tests): Correct inputs to outputs mapping for BGP tests #671

Merged
merged 6 commits into from
May 14, 2024

Conversation

gmuloc
Copy link
Collaborator

@gmuloc gmuloc commented May 13, 2024

Description

  • Rollback some modifications because commands are not created in the same order than the inputs.
  • Fix pylint 3.2.0 new warnings

Fixes #669

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@gmuloc gmuloc changed the title Fix(anta.tests): Correct inputs to outputs mapping for BGP tests fix(anta.tests): Correct inputs to outputs mapping for BGP tests May 13, 2024
Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmuloc gmuloc merged commit c33a6e5 into aristanetworks:main May 14, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: KeyError when running BGP tests
2 participants