Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Fix FAQ and other pieces of code #679

Merged
merged 5 commits into from
May 16, 2024
Merged

refactor: Fix FAQ and other pieces of code #679

merged 5 commits into from
May 16, 2024

Conversation

gmuloc
Copy link
Collaborator

@gmuloc gmuloc commented May 15, 2024

Description

  • Refactor several pieces of code:
  • remove commented out
  • Fix FAQ in doc

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@gmuloc gmuloc changed the title Sonar issues refactor: Fix FAQ and other pieces of code May 15, 2024
@gmuloc gmuloc added this to the v1.0.0 milestone May 16, 2024
@gmuloc gmuloc merged commit 28ba8e1 into aristanetworks:main May 16, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titom73 titom73 titom73 approved these changes

Assignees

@gmuloc gmuloc

Labels
rn: refactor
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gmuloc @titom73