Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(anta.cli): Make CV certs verified by default #700

Merged
merged 11 commits into from
Jun 10, 2024

Conversation

gmuloc
Copy link
Collaborator

@gmuloc gmuloc commented Jun 7, 2024

Description

Fix sonarcloud issue and another found issue when rendering the inventory.

Fixes #699

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@gmuloc gmuloc changed the title Feat(anta.cli): Make CV certs verified by default feat(anta.cli): Make CV certs verified by default Jun 7, 2024
gmuloc and others added 3 commits June 7, 2024 17:54
Co-authored-by: Carl Baillargeon <carl.baillargeon@arista.com>
Co-authored-by: Carl Baillargeon <carl.baillargeon@arista.com>
Copy link

sonarcloud bot commented Jun 7, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@titom73 titom73 added the framework-enhancement New feature or request label Jun 9, 2024
@gmuloc gmuloc merged commit e5222d1 into aristanetworks:main Jun 10, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to ignore cert and enable them by default
3 participants