Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(anta): Add support for JSON catalogs #739

Merged
merged 4 commits into from
Jul 5, 2024
Merged

feat(anta): Add support for JSON catalogs #739

merged 4 commits into from
Jul 5, 2024

Conversation

gmuloc
Copy link
Collaborator

@gmuloc gmuloc commented Jul 4, 2024

Description

Add support for JSON format for catalogs

Fixes #714

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@gmuloc gmuloc changed the title Feat(anta): Add support for JSON catalogs feat(anta): Add support for JSON catalogs Jul 4, 2024
@titom73 titom73 self-requested a review July 5, 2024 07:39
@titom73 titom73 added the framework-enhancement New feature or request label Jul 5, 2024
@titom73 titom73 added this to the v1.1.0 milestone Jul 5, 2024
titom73
titom73 approved these changes Jul 5, 2024
View reviewed changes
Copy link
Collaborator

@titom73 titom73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it ! 🚀

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

carl-baillargeon
carl-baillargeon approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carl-baillargeon carl-baillargeon merged commit ca66c4d into aristanetworks:main Jul 5, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titom73 titom73 titom73 approved these changes

@carl-baillargeon carl-baillargeon carl-baillargeon approved these changes

@mtache mtache Awaiting requested review from mtache

Assignees

@gmuloc gmuloc

Labels
framework-enhancement New feature or request rn: feat(anta)
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

Support JSON catalog
3 participants
@gmuloc @titom73 @carl-baillargeon