Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Enhance aaa to support multiple groups where available in EOS #2521

Open
1 task done
gmuloc opened this issue Feb 9, 2023 · 3 comments
Open
1 task done

Feat: Enhance aaa to support multiple groups where available in EOS #2521

gmuloc opened this issue Feb 9, 2023 · 3 comments
Labels
state: stale type: enhancement New feature or request

Comments

@gmuloc
Copy link
Contributor

gmuloc commented Feb 9, 2023

Enhancement summary

https://github.com/aristanetworks/ansible-avd/pull/2450/files#r1089721034

This EOS CLI is a bit confusing, and the documentation has a couple of typos which does not help :)
logging is a "method" similar to group abc, so it is not a property of a group.
For some reason EOS does not have a guard against repeating the same method multiple times, so that is why logging shows up after every group.
I do not know how the ordering of logging vs. group abc might affect the behavior, so until we know that, I would suggest that we skip expanding for now and just implement what we need (one group with group key similar to the rest of the models).
A future data model should probably be referring to methods which can then either be a group (with or without multicast) or logging.

dot1x:
  default:
    type: start-stop
    methods:
      - method: < logging | group >
        group: < group_name >   <-- Only relevant for method group
        multicast: < bool >     <-- Only relevant for method group   

Which component of AVD is impacted

eos_cli_config_gen

Use case example

no use case today - just tracking the outcome of the other PR.

Describe the solution you would like

support multiple groups in the future

Describe alternatives you have considered

No response

Additional context

No response

Contributing Guide

  • I agree to follow this project's Code of Conduct
@gmuloc gmuloc added the type: enhancement New feature or request label Feb 9, 2023
@gmuloc gmuloc changed the title Enhance Feat: Enhance aaa to support multiple groups where available in EOS Feb 9, 2023
@github-actions
Copy link

This issue is stale because it has been open 90 days with no activity. The issue will be reviewed by a maintainer and may be closed

@github-actions
Copy link

This issue is stale because it has been open 90 days with no activity. The issue will be reviewed by a maintainer and may be closed

Copy link

This issue is stale because it has been open 90 days with no activity. The issue will be reviewed by a maintainer and may be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: stale type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant