Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Extend aaa_accounting with options for dot1x #2450

Merged
merged 18 commits into from Feb 9, 2023
Merged

Feat(eos_cli_config_gen): Extend aaa_accounting with options for dot1x #2450

merged 18 commits into from Feb 9, 2023

Conversation

dmilyt
Copy link
Contributor

@dmilyt dmilyt commented Jan 20, 2023

Change Summary

Add aaa_accounting with options for dot1x

Related Issue(s)

Fixes #2343

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

aaa_accounting:
  dot1x:
    default:
      type: start-stop
      group: ISE_NAC

How to test

Molecule

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@dmilyt dmilyt requested a review from a team as a code owner January 20, 2023 15:38
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Jan 20, 2023
@ClausHolbechArista ClausHolbechArista changed the title Feat(eos_cli_config_gen): extend aaa_accounting with options for dot1x. Feat(eos_cli_config_gen): Extend aaa_accounting with options for dot1x Jan 23, 2023
@ClausHolbechArista ClausHolbechArista requested a review from a team February 8, 2023 15:56
gmuloc
gmuloc approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - probably should log an issue for moving to groups in the future so we track it
Thanks for the contribution!

@gmuloc
Copy link
Contributor

gmuloc commented Feb 9, 2023

LGTM - probably should log an issue for moving to groups in the future so we track it Thanks for the contribution!

#2521

@ClausHolbechArista ClausHolbechArista merged commit 40f2f30 into aristanetworks:devel Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmueller68 kmueller68 kmueller68 left review comments

@tgodaA tgodaA tgodaA left review comments

@gmuloc gmuloc gmuloc approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

Assignees

@dmilyt dmilyt

Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat(eos_cli_config_gen): extend aaa_accounting with options for dot1x
5 participants
@dmilyt @gmuloc @ClausHolbechArista @kmueller68 @tgodaA