Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make: Deactivate minify as workaround for Read the Doc #1197

Merged
merged 1 commit into from Sep 16, 2021
Merged

Make: Deactivate minify as workaround for Read the Doc #1197

merged 1 commit into from Sep 16, 2021

Conversation

titom73
Copy link
Contributor

@titom73 titom73 commented Sep 16, 2021 •
edited

Change Summary

Current RTD build is broken as a dependency of mkdocs-minify-plugin is not compatible with latest setup_tools.
This PR deactivate minify until issue is fixed on either jsmin or mkdocs-minify-plugin

Related Issue(s)

N/A

Component(s) name

mkdocs

How to test

A temporary build on RTD should be valid

image

Result is available here

Checklist

User Checklist

  • Test build on Read the Docs

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added type: dependencies Pull requests that update a dependency file type: documentation Improvements or additions to documentation labels Sep 16, 2021
@titom73 titom73 changed the title Make(mkdocs): Deactivate minify as workaround for Read the Doc Make: Deactivate minify as workaround for Read the Doc Sep 16, 2021
@titom73 titom73 added this to In progress in Repository maintenance via automation Sep 16, 2021
@titom73 titom73 added this to High priority in Priority Sep 16, 2021
ClausHolbechArista
ClausHolbechArista approved these changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@titom73 titom73 merged commit 8c621cd into aristanetworks:devel Sep 16, 2021
Repository maintenance automation moved this from In progress to Done Sep 16, 2021
Priority automation moved this from High priority to Closed Sep 16, 2021
@titom73 titom73 deleted the doc/mkdoc-rtd-minify-fix branch September 16, 2021 11:43
@titom73 titom73 mentioned this pull request Oct 1, 2021
Merged
@carlbuchmann carlbuchmann added this to the v3.0.0rc2 milestone Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@carlbuchmann carlbuchmann Awaiting requested review from carlbuchmann

@noredistribution noredistribution Awaiting requested review from noredistribution

Assignees

@titom73 titom73

Labels
type: dependencies Pull requests that update a dependency file type: documentation Improvements or additions to documentation
Projects
Priority
Closed
Repository maintenance
  
Done
Milestone
v3.0.0rc2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@titom73 @ClausHolbechArista @carlbuchmann