Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Trim documentation output to only show configured sections #2357

Merged
merged 3 commits into from Feb 3, 2023
Merged

Feat(eos_cli_config_gen): Trim documentation output to only show configured sections #2357

merged 3 commits into from Feb 3, 2023
+568 −16,914

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Trim documentation output to only show configured sections

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

  • Avoid producing documentation headings and tables with no content
  • Remove static table with EOS defaults for vlan allocations
  • Make IP routing tables dependent on actual config

How to test

  • Molecule

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR type: Python filters labels Dec 23, 2022
@github-actions github-actions bot added the role: eos_designs issue related to eos_designs role label Dec 23, 2022
@ClausHolbechArista ClausHolbechArista marked this pull request as ready for review December 23, 2022 14:30
@ClausHolbechArista ClausHolbechArista requested a review from a team as a code owner December 23, 2022 14:30
@ClausHolbechArista ClausHolbechArista force-pushed the improve-eos_cli_config_gen-doc-headings branch from ae6dd89 to 253511e Compare December 23, 2022 14:30
@ClausHolbechArista ClausHolbechArista force-pushed the improve-eos_cli_config_gen-doc-headings branch 2 times, most recently from cf1311f to 9cd3297 Compare January 9, 2023 07:53
@carlbuchmann carlbuchmann force-pushed the improve-eos_cli_config_gen-doc-headings branch from 9cd3297 to 1737bf9 Compare January 17, 2023 16:31
@JulioPDX
Copy link
Contributor

Great PR, I can see this making user interaction with docs more pleasant.

JulioPDX
JulioPDX approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@JulioPDX JulioPDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gmuloc
gmuloc approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I looked at all the templates and some of the 400+ outputs at random)

@ClausHolbechArista ClausHolbechArista force-pushed the improve-eos_cli_config_gen-doc-headings branch from fb00659 to 5d72285 Compare February 3, 2023 10:26
@ClausHolbechArista ClausHolbechArista merged commit 7d7774e into aristanetworks:devel Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc approved these changes

@JulioPDX JulioPDX JulioPDX approved these changes

@carlbuchmann carlbuchmann Awaiting requested review from carlbuchmann

Assignees

@ClausHolbechArista ClausHolbechArista

Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR type: Python filters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ClausHolbechArista @JulioPDX @gmuloc