Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Logging buffered default level not required #2364

Merged
merged 2 commits into from
Jan 2, 2023
Merged

Fix: Logging buffered default level not required #2364

merged 2 commits into from
Jan 2, 2023

Conversation

carlbuchmann
Copy link
Member

Change Summary

Logging buffered default level is not required.

Related Issue(s)

Fixes #2169

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Make logging buffered optional

How to test

See the updated molecule test case.

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@carlbuchmann carlbuchmann requested a review from a team as a code owner December 23, 2022 16:00
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR labels Dec 23, 2022
@carlbuchmann carlbuchmann modified the milestones: v3.8.0-rc1, v3.8.0-rc2 Dec 23, 2022
@carlbuchmann carlbuchmann added the type: bug Something isn't working label Dec 23, 2022
gmuloc
gmuloc approved these changes Dec 23, 2022
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once pipeline finishes

@ClausHolbechArista ClausHolbechArista merged commit d6ac909 into aristanetworks:devel Jan 2, 2023
ClausHolbechArista pushed a commit to ClausHolbechArista/avd that referenced this pull request Jan 3, 2023
@carlbuchmann @ClausHolbechArista
Fix: Logging buffered default level not required (aristanetworks#2364)
58845ba
@ClausHolbechArista ClausHolbechArista mentioned this pull request Jan 3, 2023
Merged
ClausHolbechArista added a commit that referenced this pull request Jan 4, 2023
@ClausHolbechArista @carlbuchmann
Fix: Logging buffered default level not required (#2364) (#2372)
2596dca 
Co-authored-by: Carl Buchmann <carl.buchmann@arista.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

Assignees

@carlbuchmann carlbuchmann

Labels
rn: Fix role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR type: bug Something isn't working
Projects
None yet
Milestone
v3.8.0-rc2
Development

Successfully merging this pull request may close these issues.

Logging buffered default level
3 participants
@carlbuchmann @gmuloc @ClausHolbechArista