Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Add arp learning bridged #2383

Merged
merged 3 commits into from Jan 12, 2023
Merged

Feat(eos_cli_config_gen): Add arp learning bridged #2383

merged 3 commits into from Jan 12, 2023

Conversation

tgodaA
Copy link
Contributor

@tgodaA tgodaA commented Jan 6, 2023

Change Summary

Added the knob for "arp learning bridged" as well as refactored the order as per EOS cli.

image

Related Issue(s)

Fixes #2370

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

router_l2_vpn:
  arp_learning_bridged: < true | false >

How to test

molecule converge -s eos_cli_config_gen -- --limit router-l2-vpn

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@tgodaA tgodaA requested a review from a team as a code owner January 6, 2023 17:48
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Jan 6, 2023
@tgodaA tgodaA self-assigned this Jan 6, 2023
@ClausHolbechArista ClausHolbechArista requested a review from a team January 9, 2023 07:54
gmuloc
gmuloc approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - only one comment to maybe help with readability of the device documentation but can be merged without addressing it.

...le_collections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/router-l2-vpn.md Outdated Show resolved Hide resolved
@ClausHolbechArista ClausHolbechArista merged commit b8fd627 into aristanetworks:devel Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@gmuloc gmuloc gmuloc approved these changes

Assignees

@tgodaA tgodaA

Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for "arp learning bridged"
3 participants
@tgodaA @gmuloc @ClausHolbechArista