Fix(eos_designs): overlay_rd_type with inline jinja generates incorrect config #2393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
state: CI Updated
ClausHolbechArista
approved these changes
Jan 12, 2023
ClausHolbechArista
added a commit
to ClausHolbechArista/avd
that referenced
this pull request
Jan 12, 2023
…ct config (aristanetworks#2393) Co-authored-by: Claus Holbech <holbech@arista.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
When inline jinja is used
overlay_rd_type.admin_subfieldoroverlay_rd_type.admin_subfield_offset, variables are returned as strings and cause incorrect data.We now auto-convert these fields to integers when applicable.
Component(s) name
arista.avd.eos_designsProposed changes
Updates to
/plugin_utils/eos_designs_facts.pyto convert to integers.How to test
See molecule test case.
Checklist
Repository Checklist