Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor(eos_designs): Add testcases for ipaddressing and move it to plugin utils #2410

Merged
merged 19 commits into from Nov 1, 2023
Merged

Refactor(eos_designs): Add testcases for ipaddressing and move it to plugin utils #2410

merged 19 commits into from Nov 1, 2023

Conversation

Vibhu-gslab
Copy link
Contributor

@Vibhu-gslab Vibhu-gslab commented Jan 13, 2023 •
edited by ClausHolbechArista

Change Summary

Writing unit testcase for get_ip_from_pool and move it to plugin_utils.

Proposed changes

  • Rename _ip() to get_ip_from_pool() and move to plugin_utils.utils
  • Move more IP logic from eos_designs Python modules to ip_addressing

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@Vibhu-gslab Vibhu-gslab requested a review from a team as a code owner January 13, 2023 07:21
@Vibhu-gslab Vibhu-gslab marked this pull request as draft January 13, 2023 07:21
@github-actions github-actions bot added the role: eos_designs issue related to eos_designs role label Jan 13, 2023
@Vibhu-gslab Vibhu-gslab changed the title FEAT: Adding testcases for ipaddressing and moving it to plugin utils Feat: Adding testcases for ipaddressing and moving it to plugin utils Jan 13, 2023
@ClausHolbechArista ClausHolbechArista changed the title Feat: Adding testcases for ipaddressing and moving it to plugin utils Test: Adding testcases for ipaddressing and moving it to plugin utils Jan 13, 2023
@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review January 16, 2023 13:33
@Vibhu-gslab Vibhu-gslab force-pushed the ip_addressing_unittest branch 2 times, most recently from de90b0e to 0a398bd Compare January 18, 2023 12:41
@github-actions github-actions bot added the state: conflict PR with conflict label Jan 20, 2023
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label Jan 24, 2023
@github-actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@Vibhu-gslab Vibhu-gslab force-pushed the ip_addressing_unittest branch 2 times, most recently from 9c7305d to 8eaea21 Compare February 9, 2023 05:51
@github-actions github-actions bot added the state: conflict PR with conflict label Mar 6, 2023
@github-actions
Copy link

github-actions bot commented Mar 6, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@carlbuchmann carlbuchmann added this to the v4.1.0 milestone May 30, 2023
@carlbuchmann carlbuchmann marked this pull request as draft August 4, 2023 12:26
@gmuloc gmuloc modified the milestones: v4.4.0-dev1, v4.4.0-dev2 Sep 20, 2023
@ClausHolbechArista ClausHolbechArista marked this pull request as ready for review October 18, 2023 07:14
@ClausHolbechArista ClausHolbechArista requested a review from a team as a code owner October 18, 2023 07:14
@ClausHolbechArista ClausHolbechArista requested a review from a team October 18, 2023 07:15
@ClausHolbechArista ClausHolbechArista self-assigned this Oct 18, 2023
@gmuloc gmuloc self-requested a review October 20, 2023 13:52
@carlbuchmann carlbuchmann self-requested a review October 20, 2023 13:52
@carlbuchmann carlbuchmann marked this pull request as draft October 24, 2023 20:17
ClausHolbechArista and others added 3 commits October 25, 2023 09:16
@ClausHolbechArista @gmuloc
Update ansible_collections/arista/avd/tests/unit/plugins/plugin_utils…
beb88fd 
…/test_ipaddressing.py

Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
@ClausHolbechArista
Update unit tests
002363b
@ClausHolbechArista
Update docstring
d8a15a4
@ClausHolbechArista ClausHolbechArista marked this pull request as ready for review October 25, 2023 08:35
@ClausHolbechArista ClausHolbechArista mentioned this pull request Oct 25, 2023
Merged
4 tasks
gmuloc
gmuloc approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - once CI passes

@ClausHolbechArista ClausHolbechArista requested a review from a team October 25, 2023 09:19
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Oct 25, 2023
carlbuchmann
carlbuchmann approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann merged commit 0902053 into aristanetworks:devel Nov 1, 2023
36 checks passed
@ClausHolbechArista ClausHolbechArista modified the milestones: v4.5.0-dev2, v4.5.0 Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista left review comments

@gmuloc gmuloc gmuloc approved these changes

@carlbuchmann carlbuchmann carlbuchmann approved these changes

Assignees

@ClausHolbechArista ClausHolbechArista

@Vibhu-gslab Vibhu-gslab

Labels
one approval This PR has one approval and is only missing one more. rn: Refactor(eos_designs) role: eos_designs issue related to eos_designs role
Projects
None yet
Milestone
v4.5.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Vibhu-gslab @gmuloc @carlbuchmann @ClausHolbechArista