Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor(eos_cli_config_gen)!: Require queue_monitor_length.enabled to be set #2429

Merged
merged 13 commits into from May 19, 2023
Merged

Refactor(eos_cli_config_gen)!: Require queue_monitor_length.enabled to be set #2429

merged 13 commits into from May 19, 2023

Conversation

Shivani-chourasiya
Copy link
Contributor

@Shivani-chourasiya Shivani-chourasiya commented Jan 17, 2023 •
edited by carlbuchmann

Change Summary

For queue_monitor_length data-model "enabled: true" will be required in AVD4.0.

Requires #2616

Related Issue(s)

Fixes #85

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@Shivani-chourasiya Shivani-chourasiya requested a review from a team as a code owner January 17, 2023 09:50
@Shivani-chourasiya Shivani-chourasiya changed the title Refactor(eos_cli_config_gen): Add queue_monitor_length.enabled for AVD 4.0 Refactor(eos_cli_config_gen): Add queue_monitor_length.enabled for AVD4.0 Jan 17, 2023
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR type: documentation Improvements or additions to documentation labels Jan 17, 2023
@Shivani-chourasiya Shivani-chourasiya force-pushed the AVD_4.0_eos_cli_config_gen_queue_monitor_length branch from 6e415a0 to b1cc595 Compare January 17, 2023 09:55
@ClausHolbechArista ClausHolbechArista changed the title Refactor(eos_cli_config_gen): Add queue_monitor_length.enabled for AVD4.0 Refactor(eos_cli_config_gen)!: Add queue_monitor_length.enabled for AVD4.0 Jan 17, 2023
@ClausHolbechArista ClausHolbechArista changed the title Refactor(eos_cli_config_gen)!: Add queue_monitor_length.enabled for AVD4.0 Refactor(eos_cli_config_gen)!: Require queue_monitor_length.enabled to be set Jan 17, 2023
@github-actions github-actions bot added the state: conflict PR with conflict label Jan 17, 2023
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Shivani-chourasiya Shivani-chourasiya force-pushed the AVD_4.0_eos_cli_config_gen_queue_monitor_length branch from c2751e2 to 7a140cc Compare January 18, 2023 05:50
@github-actions github-actions bot removed the state: conflict PR with conflict label Jan 18, 2023
@github-actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@Shivani-chourasiya Shivani-chourasiya force-pushed the AVD_4.0_eos_cli_config_gen_queue_monitor_length branch 2 times, most recently from e6ab13b to b12c0c2 Compare January 20, 2023 07:19
@carlbuchmann carlbuchmann mentioned this pull request Jan 20, 2023
Merged
ClausHolbechArista pushed a commit that referenced this pull request Jan 23, 2023
@carlbuchmann
Fix(eos_snapshot): eos snapshot produces incorrect json and yaml outp…
0b2eaf4 
…ut (#2426 & #2429) (#2434)
@github-actions github-actions bot added the state: conflict PR with conflict label Jan 27, 2023
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label Feb 2, 2023
@github-actions
Copy link

github-actions bot commented Feb 2, 2023

Conflicts have been resolved. A maintainer will review the pull request shortly.

@Shivani-chourasiya Shivani-chourasiya force-pushed the AVD_4.0_eos_cli_config_gen_queue_monitor_length branch from 228fb5d to 178fdf8 Compare February 2, 2023 09:23
@github-actions github-actions bot added the state: conflict PR with conflict label Feb 10, 2023
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@gmuloc gmuloc force-pushed the AVD_4.0_eos_cli_config_gen_queue_monitor_length branch from 178fdf8 to 47bdba5 Compare March 13, 2023 14:09
@github-actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@carlbuchmann carlbuchmann marked this pull request as draft March 31, 2023 14:13
@github-actions github-actions bot added the state: conflict PR with conflict label Apr 3, 2023
@github-actions
Copy link

github-actions bot commented Apr 3, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@ClausHolbechArista ClausHolbechArista added this to the v4.0.0-rc1 milestone May 15, 2023
@carlbuchmann carlbuchmann self-requested a review May 17, 2023 12:36
@Shivani-chourasiya Shivani-chourasiya force-pushed the AVD_4.0_eos_cli_config_gen_queue_monitor_length branch from bcf1346 to 368b7e8 Compare May 18, 2023 07:54
@github-actions github-actions bot removed the state: conflict PR with conflict label May 18, 2023
@github-actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@Shivani-chourasiya Shivani-chourasiya force-pushed the AVD_4.0_eos_cli_config_gen_queue_monitor_length branch from 368b7e8 to 37fc4bc Compare May 18, 2023 08:03
@Shivani-chourasiya Shivani-chourasiya marked this pull request as ready for review May 18, 2023 08:16
@Shivani-chourasiya Shivani-chourasiya force-pushed the AVD_4.0_eos_cli_config_gen_queue_monitor_length branch from c001a99 to 3a01346 Compare May 18, 2023 08:19
chetryan
chetryan approved these changes May 19, 2023
View reviewed changes
Copy link
Contributor

@chetryan chetryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carlbuchmann carlbuchmann merged commit 24153c6 into aristanetworks:devel May 19, 2023
35 checks passed
@Shivani-chourasiya Shivani-chourasiya removed their assignment Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc left review comments

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@chetryan chetryan chetryan approved these changes

@carlbuchmann carlbuchmann Awaiting requested review from carlbuchmann

Assignees
No one assigned
Labels
EPIC - AVD 4.0 rn: Refactor(eos_cli_config_gen)! role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: documentation Improvements or additions to documentation
Projects
None yet
Milestone
v4.0.0-rc1
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Shivani-chourasiya @gmuloc @ClausHolbechArista @chetryan @carlbuchmann @Shivani-gslab