Feat(eos_designs, eos_cli_config_gen)!: Remove default "switchport" and remove logic from eos_cli_config_gen

[ClausHolbechArista]

Change Summary

Remove default "switchport" and remove logic from eos_cli_config_gen

These changes are potentially breaking for users of eos_cli_config_gen, they will be transparent for users of eos_designs.

Component(s) name

• arista.avd.eos_designs
• arista.avd.eos_cli_config_gen

Proposed changes

Fixes: aristanetworks/avd-internal#89

eos_cli_config_gen

1. Remove undocumented default value of type under ethernet_interfaces and port_channel_interfaces. It was 'switched'
2. Result of 1. is that interface configs will no longer render switchport unless type: 'switched' is specifically set.
3. Remove print_ethernet logic from ethernet_interfaces jinja template in eos_cli_config_gen, to no longer ignore interface settings on port-channel members.
4. Update device documentation templates to only print interfaces under L2 Interfaces if type == 'switched'
5. Update molecule data with type where needed.
6. Fix a couple of files with erronous molecule data - hidden by previous print_ethernet logic.
7. Update old documentation to show type for switched interfaces.
8. Update schema with note on type is required for the interface to show up in documentation (previously it defaulted to switched so interfaces without type showed up under "L2 Interfaces".

re. 8. this will change when we refactor to classify interfaces based on actual config keys instead of type.

eos_designs

1. Update eos_designs to add type as required to all generated interface configs
2. Update eos_designs to only render valid config for port_channel members (was previously ignored because of the print_ethernet logic in eos_cli_config_gen
3. Adjust molecule configs to render the same configs as before. Structured configs change because of reordering and removal of invalid configs, but no cfg changes.

How to test

Updated molecule scenarios to render the same configs for eos_designs

Updated molecule scenarios to render mostly the same configs for eos_cli_config_gen. A few fixes have been done for wrongful switchport under subinterface and trunk information on port-channel member.

Checklist

User Checklist

• N/A

Repository Checklist

• My code has been rebased from devel before I start
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation and documentation have been updated accordingly.
• I have updated molecule CI testing accordingly. (check the box if not applicable)

[tgodaA]

Why am I seeing the changes of Schemas but not the switchport. Something looks wrong @ClausHolbechArista

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[emilarista]

Reviewed code + ran against a few different repositories. No unexpected config changes seen. LGTM!

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[carlbuchmann]

LGTM!