Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Add aaa authorization policy and dynamic #2440

Merged
merged 5 commits into from
Feb 15, 2023
Merged

Feat(eos_cli_config_gen): Add aaa authorization policy and dynamic #2440

merged 5 commits into from
Feb 15, 2023

Conversation

tgodaA
Copy link
Contributor

@tgodaA tgodaA commented Jan 18, 2023

Change Summary

Add the aaa authorization policy and dynamic commands.

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

aaa_authorization:
  policy:
    local_default_role: < role_name >
  dynamic:
    dot1x_additional_groups:
      - < group_name >

How to test

pre-commit run -a
molecule converge -s eos_cli_config_gen -- --limit aaa

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@tgodaA tgodaA requested a review from a team as a code owner January 18, 2023 21:50
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Jan 18, 2023
@tgodaA
Copy link
Contributor Author

tgodaA commented Jan 18, 2023

Tested commands on a device:

image

@tgodaA tgodaA added this to the 3.8.1 milestone Jan 18, 2023
@tgodaA tgodaA requested a review from gmuloc January 20, 2023 17:04
@carlbuchmann carlbuchmann removed this from the 3.8.1 milestone Jan 20, 2023
emilarista
emilarista approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@emilarista emilarista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgodaA tgodaA requested review from gmuloc and removed request for gmuloc February 2, 2023 14:52
@github-actions github-actions bot added the state: conflict PR with conflict label Feb 10, 2023
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label Feb 13, 2023
@github-actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@ClausHolbechArista ClausHolbechArista merged commit 3d0ed2d into aristanetworks:devel Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@emilarista emilarista emilarista approved these changes

@gmuloc gmuloc Awaiting requested review from gmuloc

Assignees

@tgodaA tgodaA

Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tgodaA @gmuloc @ClausHolbechArista @emilarista @carlbuchmann