Fix(eos_designs): Fix issue with hardware_counters python code #2447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmuloc
added
the
cherry-pick-for-3.8.x
github-actions
bot
added
role: eos_designs
github-actions
bot
added
role: eos_cli_config_gen
ClausHolbechArista
approved these changes
Jan 20, 2023
...ections/arista/avd/molecule/eos_designs_unit_tests/inventory/host_vars/hardware_counters.yml
Outdated
Show resolved
Hide resolved
carlbuchmann
pushed a commit
to carlbuchmann/avd
that referenced
this pull request
Jan 23, 2023
…anetworks#2447) Co-authored-by: Claus Holbech <holbech@arista.com>
carlbuchmann
removed
the
cherry-pick-for-3.8.x
carlbuchmann
added a commit
that referenced
this pull request
Jan 23, 2023
#2454) Co-authored-by: Claus Holbech <holbech@arista.com> Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
When porting from AVD 3.7.0 jinja2 template to AVD3.8.0 python module, the logic was not correctly implemented and it was not caught up at implementation time because no test existed in molecule for
hardware_counters.featuresComponent(s) name
arista.avd.eos_designsProposed changes
As we are only copying over the list of dictionaries, removing the double for loop and just injecting the incoming data.
How to test
new molecule test for it in `eos_designs_unit_test
Checklist