Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(eos_cli_config_gen): Fix the router_multicast vrfs indentation #2476

Merged
merged 1 commit into from
Feb 2, 2023
Merged

Fix(eos_cli_config_gen): Fix the router_multicast vrfs indentation #2476

merged 1 commit into from
Feb 2, 2023

Conversation

tgodaA
Copy link
Contributor

@tgodaA tgodaA commented Jan 31, 2023

Change Summary

Fix the router_multicast.vrfs configuration indentation

Related Issue(s)

Fixes #2474

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

How to test

All molecule tests should pass or run locally

make refresh-facts

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@tgodaA tgodaA requested a review from a team as a code owner January 31, 2023 15:20
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR labels Jan 31, 2023
gmuloc
gmuloc approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann added the cherry-pick-for-3.8.x PR to be cherry-picked to releases/v3.8.x brach later label Feb 2, 2023
@carlbuchmann carlbuchmann self-requested a review February 2, 2023 19:08
carlbuchmann
carlbuchmann approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carlbuchmann carlbuchmann merged commit 601f404 into aristanetworks:devel Feb 2, 2023
@carlbuchmann carlbuchmann added this to the v3.8.2 milestone Feb 13, 2023
carlbuchmann pushed a commit to carlbuchmann/avd that referenced this pull request Feb 13, 2023
@tgodaA @carlbuchmann
Fix(eos_cli_config_gen): Fix the router_multicast vrfs indentation (a…
d707753 
…ristanetworks#2476)
@carlbuchmann carlbuchmann mentioned this pull request Feb 13, 2023
Merged
@carlbuchmann carlbuchmann removed the cherry-pick-for-3.8.x PR to be cherry-picked to releases/v3.8.x brach later label Feb 13, 2023
ClausHolbechArista pushed a commit that referenced this pull request Feb 14, 2023
@carlbuchmann @tgodaA
Fix(eos_cli_config_gen): Fix the router_multicast vrfs indentation (#…
356a4a3 
…2476) (#2527)

Co-authored-by: Tony Reddy Goda <tgoda@arista.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc approved these changes

@carlbuchmann carlbuchmann carlbuchmann approved these changes

Assignees

@tgodaA tgodaA

Labels
rn: Fix(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Milestone
v3.8.2
Development

Successfully merging this pull request may close these issues.

Fix(eos_cli_config_gen): router_multicast vrfs indentation is mismatched
3 participants
@tgodaA @gmuloc @carlbuchmann