Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): extend ethernet_interface with dot1x eapol authentication_failure_falback #2482

Merged
merged 60 commits into from Mar 3, 2023
Merged

Feat(eos_cli_config_gen): extend ethernet_interface with dot1x eapol authentication_failure_falback #2482

merged 60 commits into from Mar 3, 2023

Conversation

dmilyt
Copy link
Contributor

@dmilyt dmilyt commented Feb 1, 2023 •
edited

Change Summary

extend ethernet_interface with dot1x eapol authentication_failure_falback

Related Issue(s)

Fixes #2344

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

ethernet_interfaces:
  Ethernet_Interface_2:
    dot1x:
      eapol:
        disabled: < true | false >
        authentication_failure_fallback_mba:
          enabled: < true | false >
          timeout: < 0-65535 > in seconds

How to test

Molecule

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@dmilyt dmilyt requested a review from a team as a code owner February 1, 2023 15:32
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Feb 1, 2023
@github-actions github-actions bot removed the state: conflict PR with conflict label Feb 15, 2023
@github-actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@carlbuchmann carlbuchmann added this to the v4.0.0-dev6 milestone Feb 24, 2023
tgodaA
tgodaA approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@tgodaA tgodaA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gmuloc
gmuloc reviewed Mar 2, 2023
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is no test for the new feature? (all the Eapol values are - in all the tests)

@dmilyt
Copy link
Contributor Author

dmilyt commented Mar 3, 2023

Looks like there is no test for the new feature? (all the Eapol values are - in all the tests)
Now looks beter:

dot1x eapol authentication failure fallback mba timeout 600

Interface PAE Mode State Phone Force Authorized Reauthentication Auth Failure Action Host Mode Mac Based Auth Eapol
Ethernet45 authenticator auto - True allow vlan 800 multi-host True True

gmuloc
gmuloc approved these changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks for the updates @dmilyt - will merge this once the CI finishes

@gmuloc gmuloc dismissed ClausHolbechArista’s stale review March 3, 2023 13:17

Changes have been addressed

@gmuloc
Copy link
Contributor

gmuloc commented Mar 3, 2023

Pipeline failing is unrelated to the PR but to a new version of ansible-lint - merging the PR and the pipeline issue will be resolved elsewhere.

@gmuloc gmuloc merged commit 083140c into aristanetworks:devel Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc approved these changes

@tgodaA tgodaA tgodaA approved these changes

@ClausHolbechArista ClausHolbechArista Awaiting requested review from ClausHolbechArista

Assignees

@dmilyt dmilyt

Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
v4.0.0-dev6
Development

Successfully merging this pull request may close these issues.

Feat(eos_cli_config_gen): extend ethernet_interface with dot1x eapol authentication_failure_falback
5 participants
@dmilyt @gmuloc @ClausHolbechArista @tgodaA @carlbuchmann