Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_designs): Only require 'virtual_router_mac_address' when using VARP or anycast IP on SVIs #2485

Merged
merged 4 commits into from Mar 3, 2023
Merged

Feat(eos_designs): Only require 'virtual_router_mac_address' when using VARP or anycast IP on SVIs #2485

merged 4 commits into from Mar 3, 2023

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Only require 'virtual_router_mac_address' when using VARP or anycast IP on SVIs

Related Issue(s)

Fixes #2473

Component(s) name

arista.avd.eos_designs

Proposed changes

  • Remove static requirement for virtual_router_mac_address
  • Update docs
  • Add check for mac during rendering of SVIs and emit errors accordingly
  • Update molecule group_vars under eos_designs_unit_tests to only set the virtual mac where needed.

How to test

  • Removed the mac from the unit test groups vars where not strictly required. Still works.
  • Tested with removing the mac from some of the remaining unit test group vars and saw the errors being raised.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ClausHolbechArista ClausHolbechArista requested a review from a team as a code owner February 3, 2023 13:07
@github-actions github-actions bot added role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Feb 3, 2023
@gmuloc
Copy link
Contributor

gmuloc commented Feb 8, 2023

@ClausHolbechArista - FYI pushed a PR on your branch: ClausHolbechArista#24

@carlbuchmann carlbuchmann added this to the v4.0.0-dev6 milestone Feb 24, 2023
emilarista
emilarista approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@emilarista emilarista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

tgodaA
tgodaA approved these changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@tgodaA tgodaA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit 728df46 into aristanetworks:devel Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlbuchmann carlbuchmann carlbuchmann left review comments

@emilarista emilarista emilarista approved these changes

@tgodaA tgodaA tgodaA approved these changes

@chetryan chetryan Awaiting requested review from chetryan

Assignees

@ClausHolbechArista ClausHolbechArista

Labels
rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
v4.0.0-dev6
Development

Successfully merging this pull request may close these issues.

Unable to not use virtual-router mac-address
5 participants
@ClausHolbechArista @gmuloc @carlbuchmann @emilarista @tgodaA