Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_designs): User defined description on management interface #2500

Merged
merged 1 commit into from
Feb 9, 2023
Merged

Feat(eos_designs): User defined description on management interface #2500

merged 1 commit into from
Feb 9, 2023

Conversation

ClausHolbechArista
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista commented Feb 8, 2023 •
edited
Loading

Change Summary

User defined descriptions on management interface

Fixes #2392

Component(s) name

arista.avd.eos_designs

Proposed changes

mgmt_interface_description: < description | default -> "oob_management" >

How to test

Added to molecule

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ClausHolbechArista ClausHolbechArista requested a review from a team as a code owner February 8, 2023 14:40
@github-actions github-actions bot added role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Feb 8, 2023
@ClausHolbechArista ClausHolbechArista changed the title Feat(eos_designs): User defined descriptions on management interface Feat(eos_designs): User defined description on management interface Feb 8, 2023
@ClausHolbechArista ClausHolbechArista added this to To Do in DK-PROJECT-02 via automation Feb 8, 2023
@ClausHolbechArista ClausHolbechArista added this to the v4.0.0-dev3 milestone Feb 8, 2023
@ClausHolbechArista ClausHolbechArista linked an issue Feb 8, 2023 that may be closed by this pull request
eos_designs: Allow a custom mgmt interface description #2392
Closed
1 task
emilarista
emilarista approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@emilarista emilarista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ClausHolbechArista ClausHolbechArista merged commit c5c46fc into aristanetworks:devel Feb 9, 2023
DK-PROJECT-02 automation moved this from To Do to Done Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippebureau philippebureau philippebureau approved these changes

@emilarista emilarista emilarista approved these changes

Assignees

@ClausHolbechArista ClausHolbechArista

Labels
rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
DK-PROJECT-02
  
Done
Milestone
v4.0.0-dev3
Development

Successfully merging this pull request may close these issues.

eos_designs: Allow a custom mgmt interface description
3 participants
@ClausHolbechArista @philippebureau @emilarista