Fix!: Change uppercase CVP role vars to lower case

[ClausHolbechArista]

Change Summary

Change uppercase CVP role vars to lower case

Potentially breaking in rare cases where custom logic relies on the registered vars or content of files.

Component(s) name

Roles:
arista.avd.eos_config_deploy_cvp
arista.avd.cvp_configlet_upload

Modules:
arista.avd.inventory_to_container
arista.avd.configlet_build_config

Proposed changes

Change registered vars in above roles/modules from uppercase to lowercase, to conform with Ansible linting requirements.

CVP_CONFIGLETS -> cvp_configlets
CVP_CONFIGLETS_STATUS -> cvp_configlets_status
CVP_CONTAINERS -> cvp_containers
CVP_CONTAINER_RESULTS -> cvp_container_results
CVP_DEVICES -> cvp_devices
CVP_DEVICES_RESULTS -> cvp_devices_results
CVP_FACTS -> cvp_facts
CVP_TOPOLOGY -> cvp_topology
CVP_VARS -> cvp_vars

How to test

All existing integration tests and molecule have been updated.

Checklist

User Checklist

• N/A

Repository Checklist

• My code has been rebased from devel before I start
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation and documentation have been updated accordingly.
• I have updated molecule CI testing accordingly. (check the box if not applicable)

[gmuloc]

LGTM - only suggestion for the release notes - though maybe it should be in the porting guide?

[gmuloc]

Suggested change

	Modules:
	arista.avd.inventory_to_container
	arista.avd.configlet_build_config
	Modules:
	* arista.avd.inventory_to_container
	* arista.avd.configlet_build_config

[ClausHolbechArista]

Implemented the fixes. I don't think we should have this in the porting guide, since we have no way of knowing how the vars are consumed by custom logic.

[carlbuchmann]

LGTM!