Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): extend radius_servers with attribute 32 include in access and dynamic-authorization #2523

Merged
merged 45 commits into from Mar 6, 2023
Merged

Feat(eos_cli_config_gen): extend radius_servers with attribute 32 include in access and dynamic-authorization #2523

merged 45 commits into from Mar 6, 2023

Conversation

dmilyt
Copy link
Contributor

@dmilyt dmilyt commented Feb 10, 2023

Change Summary

Add radius_servers with attribute 32 include in access and dynamic-authorization

Related Issue(s)

Fixes #2342

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

radius_server:
 attribute_32_include_in_access_req:
   hostname: < true | false >
   format: < LINE >
 dynamic_authorization:
   port: < port_number >
   tls_ssl_profile: < profile >
 hosts:
   - host: < host IP address or name >
     vrf: < vrf_name >
     key: < encrypted_key >
     timeout: < 1-1000 > in seconds
     retransmit: < 0-100 >

How to test

Molecule

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@dmilyt dmilyt requested a review from a team as a code owner February 10, 2023 13:34
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Feb 10, 2023
@dmilyt dmilyt changed the title extend radius_servers with attribute 32 include in access and dynamic-authorization Feat(eos_cli_config_gen): extend radius_servers with attribute 32 include in access and dynamic-authorization Feb 10, 2023
@github-actions github-actions bot added the state: conflict PR with conflict label Feb 10, 2023
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label Feb 14, 2023
@github-actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

ClausHolbechArista
ClausHolbechArista requested changes Feb 15, 2023
View reviewed changes
...ctions/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/radius_server.schema.yml Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos-device-documentation.j2 Outdated Show resolved Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/aaa.yml Outdated Show resolved Hide resolved
...ble_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/radius-server.j2 Show resolved Hide resolved
...ble_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/radius-server.j2 Outdated Show resolved Hide resolved
...ctions/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/radius_server.schema.yml Outdated Show resolved Hide resolved
...ctions/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/radius_server.schema.yml Outdated Show resolved Hide resolved
...ctions/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/radius_server.schema.yml Outdated Show resolved Hide resolved
...ctions/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/radius_server.schema.yml Outdated Show resolved Hide resolved
...ctions/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/radius_server.schema.yml Outdated Show resolved Hide resolved
dmilyt and others added 11 commits February 15, 2023 13:18
@dmilyt @ClausHolbechArista
Update ansible_collections/arista/avd/roles/eos_cli_config_gen/templa…
b02bf13 
…tes/documentation/radius-server.j2

Co-authored-by: Claus Holbech <holbech@arista.com>
@dmilyt @ClausHolbechArista
Update ansible_collections/arista/avd/molecule/eos_cli_config_gen/inv…
941d44e 
…entory/host_vars/aaa.yml

Co-authored-by: Claus Holbech <holbech@arista.com>
@dmilyt @ClausHolbechArista
Update ansible_collections/arista/avd/roles/eos_cli_config_gen/schema…
c84d498 
…s/schema_fragments/radius_server.schema.yml

Co-authored-by: Claus Holbech <holbech@arista.com>
@dmilyt @ClausHolbechArista
Update ansible_collections/arista/avd/roles/eos_cli_config_gen/schema…
7a2d7b4 
…s/schema_fragments/radius_server.schema.yml

Co-authored-by: Claus Holbech <holbech@arista.com>
@dmilyt @ClausHolbechArista
Update ansible_collections/arista/avd/roles/eos_cli_config_gen/schema…
ac419b6 
…s/schema_fragments/radius_server.schema.yml

Co-authored-by: Claus Holbech <holbech@arista.com>
@dmilyt @ClausHolbechArista
Update ansible_collections/arista/avd/roles/eos_cli_config_gen/templa…
8a79b25 
…tes/eos/radius-server.j2

Co-authored-by: Claus Holbech <holbech@arista.com>
@dmilyt @ClausHolbechArista
Update ansible_collections/arista/avd/roles/eos_cli_config_gen/templa…
55f35d6 
…tes/eos/radius-server.j2

Co-authored-by: Claus Holbech <holbech@arista.com>
@dmilyt @ClausHolbechArista
Update ansible_collections/arista/avd/roles/eos_cli_config_gen/templa…
caad3a9 
…tes/eos/radius-server.j2

Co-authored-by: Claus Holbech <holbech@arista.com>
@dmilyt @ClausHolbechArista
Update ansible_collections/arista/avd/roles/eos_cli_config_gen/templa…
8ea20f1 
…tes/eos/radius-server.j2

Co-authored-by: Claus Holbech <holbech@arista.com>
@dmilyt @ClausHolbechArista
Update ansible_collections/arista/avd/roles/eos_cli_config_gen/templa…
60661d5 
…tes/eos/radius-server.j2

Co-authored-by: Claus Holbech <holbech@arista.com>
@dmilyt
Merge branch 'devel' into 2342
2ba10db
@gmuloc
Copy link
Contributor

gmuloc commented Mar 3, 2023

@ClausHolbechArista - as discussed let's add a schema deprecation on the old model in this PR.

@dmilyt Claus will take care of this on Monday to get your PR through.

@ClausHolbechArista
Copy link
Contributor

@ClausHolbechArista - as discussed let's add a schema deprecation on the old model in this PR.

@dmilyt Claus will take care of this on Monday to get your PR through.

@gmuloc done. Ready for review

gmuloc
gmuloc approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmuloc gmuloc merged commit a9d5851 into aristanetworks:devel Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

Assignees

@dmilyt dmilyt

Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat(eos_cli_config_gen): extend radius_servers with attribute 32 include in access and dynamic-authorization
3 participants
@dmilyt @gmuloc @ClausHolbechArista