Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add 'route_reflector_client' key to BGP neighbor in VRF #2551

Merged
merged 3 commits into from Feb 25, 2023

Conversation

gusmb
Copy link
Contributor

@gusmb gusmb commented Feb 20, 2023

Change Summary

Add support for the following key at BGP neighbor level under VRF:

route_reflector_client: < true | false >

Related Issue(s)

Fixes #2548

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Modify schemas and add missing key to the data structure and molecule tests

How to test

See molecule scenario

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gusmb gusmb requested a review from a team as a code owner February 20, 2023 11:05
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Feb 20, 2023
@ClausHolbechArista ClausHolbechArista requested a review from a team February 24, 2023 06:42
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution!

@ClausHolbechArista ClausHolbechArista requested a review from a team February 24, 2023 06:43
@carlbuchmann carlbuchmann added this to the v4.0.0-dev6 milestone Feb 24, 2023
Copy link
Contributor

@jonxstill jonxstill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ClausHolbechArista ClausHolbechArista merged commit 893ed07 into aristanetworks:devel Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat(eos_cli_config_gen): Add 'route_reflector_client' key to BGP neighbor in VRF
4 participants