Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_config_deploy_cvp): Add support for device_inventory_mode #2561

Merged
merged 7 commits into from Oct 12, 2023
Merged

Feat(eos_config_deploy_cvp): Add support for device_inventory_mode #2561

merged 7 commits into from Oct 12, 2023

Conversation

ClausHolbechArista
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista commented Feb 22, 2023 •
edited

Change Summary

Add support for device_inventory_mode

Related Issue(s)

Fixes #2380

Component(s) name

arista.avd.eos_config_deploy_cvp

Proposed changes

Adding new options:

  • device_inventory_mode: strict / loose. Define how missing devices are handled. "loose" will ignore missing devices. "strict" will fail on any missing device. Default: strict. NOTE: This option requires arista.cvp collection version >= 3.8.0.

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_config_deploy_cvp issue related to eos_config_deploy_cvp role state: Documentation role Updated labels Feb 22, 2023
@ClausHolbechArista ClausHolbechArista mentioned this pull request Feb 22, 2023
Closed
@github-actions github-actions bot added the type: documentation Improvements or additions to documentation label Feb 22, 2023
@ClausHolbechArista ClausHolbechArista mentioned this pull request Feb 22, 2023
Closed
1 task
@ClausHolbechArista ClausHolbechArista added this to To Do in DK-PROJECT-02 via automation Feb 22, 2023
@ClausHolbechArista ClausHolbechArista mentioned this pull request Apr 11, 2023
Merged
4 tasks
@github-actions github-actions bot added the state: conflict PR with conflict label Apr 14, 2023
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@carlbuchmann carlbuchmann added this to the v4.1.0 milestone May 30, 2023
@ClausHolbechArista ClausHolbechArista removed this from the v4.1.0 milestone Jun 15, 2023
@sugetha24 sugetha24 marked this pull request as ready for review September 27, 2023 23:05
@sugetha24 sugetha24 requested review from a team as code owners September 27, 2023 23:05
@github-actions github-actions bot removed the state: conflict PR with conflict label Sep 27, 2023
@github-actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot added state: conflict PR with conflict and removed type: documentation Improvements or additions to documentation state: conflict PR with conflict labels Sep 27, 2023
@github-actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@chetryan
Copy link
Contributor

chetryan commented Oct 4, 2023

It looks to me that this change is only introducing device_inventory_mode , could we update the MR description to reflect this?

@ClausHolbechArista ClausHolbechArista changed the title Feat(eos_config_deploy_cvp): Allow setting arista.cvp options from AVD Feat(eos_config_deploy_cvp): Add support for device_inventory_mode Oct 6, 2023
noredistribution
noredistribution approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@noredistribution noredistribution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested against the latest CV 2023.2.0 and worked like a charm! +1

@ClausHolbechArista ClausHolbechArista merged commit cfd50d6 into aristanetworks:devel Oct 12, 2023
37 checks passed
DK-PROJECT-02 automation moved this from To Do to Done Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sugetha24 sugetha24 sugetha24 approved these changes

@noredistribution noredistribution noredistribution approved these changes

Assignees

@ClausHolbechArista ClausHolbechArista

Labels
rn: Feat(eos_config_deploy_cvp) role: eos_config_deploy_cvp issue related to eos_config_deploy_cvp role state: Documentation role Updated
Projects
DK-PROJECT-02
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

eos_config_deploy_cvp: Missing documentation of apply_mode
5 participants
@ClausHolbechArista @chetryan @sugetha24 @noredistribution @carlbuchmann