Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Add address locking options on ethernet interfaces #2564

Merged
merged 12 commits into from
Mar 31, 2023
Merged

Feat(eos_cli_config_gen): Add address locking options on ethernet interfaces #2564

merged 12 commits into from
Mar 31, 2023

Conversation

emilarista
Copy link
Contributor

Change Summary

Adds address locking data model to ethernet interfaces.

Depends on #2560

Related Issue(s)

Fixes #2313

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

ethernet_interfaces:
  EthernetX:
    address_locking:
      ipv4: bool
      ipv6: bool

How to test

Tested with molecule and on physical device.

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Feb 22, 2023
@github-actions github-actions bot added the state: conflict PR with conflict label Mar 10, 2023
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label Mar 28, 2023
@github-actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@emilarista emilarista marked this pull request as ready for review March 28, 2023 09:33
@emilarista emilarista requested a review from a team as a code owner March 28, 2023 09:33
@gmuloc gmuloc added this to the v4.0.0-dev9 milestone Mar 30, 2023
emilarista and others added 2 commits March 30, 2023 13:25
@emilarista @gmuloc
Update ansible_collections/arista/avd/roles/eos_cli_config_gen/templa…
bd4a4db 
…tes/documentation/address-locking.j2

Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
@carlbuchmann
update documentation
d216bfa
carlbuchmann
carlbuchmann approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit 2725098 into aristanetworks:devel Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc approved these changes

@carlbuchmann carlbuchmann carlbuchmann approved these changes

Assignees

@emilarista emilarista

Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
v4.0.0-dev9
Development

Successfully merging this pull request may close these issues.

IP Locking in eos_cli_config_gen
4 participants
@emilarista @gmuloc @carlbuchmann @ClausHolbechArista