Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_designs): Allow disabling filtering on redist connected in underlay bgp #2586

Merged
merged 4 commits into from Mar 7, 2023
Merged

Feat(eos_designs): Allow disabling filtering on redist connected in underlay bgp #2586

merged 4 commits into from Mar 7, 2023

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Allow disabling filtering on redist connected in underlay bgp

Component(s) name

arista.avd.eos_designs

Proposed changes

# Filter redistribution of connected into underlay routing protocol.
# Only applicable when overlay_routing_protocol != 'none' and underlay_routing_protocol == BGP.
# Creates a route-map and prefix-list assigned to redistribute connected permitting only loopbacks and inband management subnets.
underlay_filter_redistribute_connected: < true | false | default -> true >

How to test

Added to molecule

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ClausHolbechArista ClausHolbechArista requested a review from a team as a code owner February 28, 2023 19:55
@github-actions github-actions bot added role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated state: conflict PR with conflict labels Feb 28, 2023
@github-actions
Copy link

github-actions bot commented Mar 1, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

gmuloc
gmuloc reviewed Mar 2, 2023
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall - just need following the latest changes in devel

ansible_collections/arista/avd/roles/eos_designs/python_modules/network_services/route_maps.py Outdated
@@ -119,6 +109,22 @@ def _route_maps_vrf_default(self) -> dict | None:
"match": ["ip address prefix-list PL-STATIC-VRF-DEFAULT"],
}

if self._underlay_filter_redistribute_connected:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to rebase to take into account the new route-map syntax - maybe let's keep the ordering of generation (RM-CONN before RM-EVPN if both present?)

@github-actions github-actions bot removed the state: conflict PR with conflict label Mar 6, 2023
@github-actions
Copy link

github-actions bot commented Mar 6, 2023

Conflicts have been resolved. A maintainer will review the pull request shortly.

gmuloc
gmuloc approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista requested a review from a team March 6, 2023 14:39
emilarista
emilarista approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@emilarista emilarista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmuloc gmuloc force-pushed the underlay-filter-connected branch from aa45723 to 7d59283 Compare March 7, 2023 14:59
@github-actions github-actions bot added the state: conflict PR with conflict label Mar 7, 2023
@github-actions
Copy link

github-actions bot commented Mar 7, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@gmuloc gmuloc force-pushed the underlay-filter-connected branch from 7d59283 to ac81210 Compare March 7, 2023 15:12
@github-actions github-actions bot removed the state: conflict PR with conflict label Mar 7, 2023
@github-actions
Copy link

github-actions bot commented Mar 7, 2023

Conflicts have been resolved. A maintainer will review the pull request shortly.

@ClausHolbechArista ClausHolbechArista added this to the v4.0.0-dev6 milestone Mar 7, 2023
@ClausHolbechArista ClausHolbechArista merged commit 4f17785 into aristanetworks:devel Mar 7, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc approved these changes

@emilarista emilarista emilarista approved these changes

Assignees

@ClausHolbechArista ClausHolbechArista

Labels
rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
v4.0.0-dev6
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ClausHolbechArista @gmuloc @emilarista