Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_designs): Add support for overlay_routing_protocol CVX #2600

Merged
merged 4 commits into from Mar 7, 2023
Merged

Feat(eos_designs): Add support for overlay_routing_protocol CVX #2600

merged 4 commits into from Mar 7, 2023

Conversation

ClausHolbechArista
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista commented Mar 7, 2023 •
edited

Change Summary

Add support for overlay_routing_protocol CVX

Related Issue(s)

Fixes #2004

Component(s) name

arista.avd.eos_designs

Proposed changes

overlay_routing_protocol: < EBGP | IBGP | HER | CVX | none | default for l3ls-evpn -> EBGP >

# Overlay settings when using CVX as overlay controller | Required if overlay_routing_protocol == CVX
overlay_cvx_servers: [ < cvx1_ip_or_hostname >, < cvx2_ip_or_hostname >, < cvx3_ip_or_hostname > ]

How to test

Added molecule converage

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ClausHolbechArista ClausHolbechArista requested a review from a team as a code owner March 7, 2023 13:25
@github-actions github-actions bot added role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Mar 7, 2023
@ClausHolbechArista ClausHolbechArista changed the title Feat(eos_design): Add support for overlay_routing_protocol CVX Feat(eos_designs): Add support for overlay_routing_protocol CVX Mar 7, 2023
@ClausHolbechArista ClausHolbechArista added this to To Do in DK-PROJECT-02 via automation Mar 7, 2023
@ClausHolbechArista ClausHolbechArista added this to the v4.0.0-dev6 milestone Mar 7, 2023
gmuloc
gmuloc previously requested changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR seems to trigger changes in HER - will investigate a bit further

ansible_collections/arista/avd/roles/eos_designs/python_modules/overlay/management_cvx.py Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_designs/python_modules/overlay/router_bfd.py Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_designs/python_modules/overlay/router_bgp.py Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_designs/python_modules/overlay/route_maps.py Show resolved Hide resolved
DK-PROJECT-02 automation moved this from To Do to In Progress Mar 7, 2023
carlbuchmann
carlbuchmann approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carlbuchmann carlbuchmann merged commit 89d2758 into aristanetworks:devel Mar 7, 2023
31 checks passed
DK-PROJECT-02 automation moved this from In Progress to Done Mar 7, 2023
@ClausHolbechArista ClausHolbechArista mentioned this pull request Mar 24, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlbuchmann carlbuchmann carlbuchmann approved these changes

@gmuloc gmuloc Awaiting requested review from gmuloc

Assignees

@ClausHolbechArista ClausHolbechArista

Labels
rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
DK-PROJECT-02
  
Done
Milestone
v4.0.0-dev6
Development

Successfully merging this pull request may close these issues.

Feat(eos_designs): Support for overlay_routing_protocol: CVX
3 participants
@ClausHolbechArista @gmuloc @carlbuchmann