Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(eos_designs): Duplicate route-maps generated when using underlay_filter_peer_as: true #2612

Merged
merged 2 commits into from Mar 10, 2023

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Mar 9, 2023

Change Summary

In some cases when a leaf is configured with underlay_filter_peer_as: true and has multiple peers with the same AS, the same route-map is generated multiple times

Related Issue(s)

Fixes #2610

Component(s) name

arista.avd.eos_designs

Proposed changes

Make sure the AS for route-maps are unique.

How to test

New molecule test passes

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Mar 9, 2023
@github-actions github-actions bot added the role: eos_designs issue related to eos_designs role label Mar 9, 2023
@gmuloc gmuloc marked this pull request as ready for review March 9, 2023 17:29
@gmuloc gmuloc requested a review from a team as a code owner March 9, 2023 17:29
@carlbuchmann carlbuchmann added cherry-pick-for-3.8.x PR to be cherry-picked to releases/v3.8.x brach later type: bug Something isn't working labels Mar 9, 2023
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM reviewed the test scenario.

@ClausHolbechArista ClausHolbechArista merged commit 1d0f548 into aristanetworks:devel Mar 10, 2023
34 checks passed
carlbuchmann pushed a commit to carlbuchmann/avd that referenced this pull request Mar 20, 2023
@carlbuchmann carlbuchmann removed the cherry-pick-for-3.8.x PR to be cherry-picked to releases/v3.8.x brach later label Mar 20, 2023
carlbuchmann added a commit that referenced this pull request Mar 20, 2023
…filter_peer_as: true (#2612) (#2640)

Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Fix(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(eos_designs): After refactoring, duplicate route-maps can be generated for filtering underlay peer AS
3 participants