Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(eos_designs): Raise correct error message for duplicate port-channels #2674

Merged
merged 5 commits into from
Mar 31, 2023

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Mar 30, 2023

Change Summary

Wrong structure used to return error message

Related Issue(s)

Raised by user while testing

Component(s) name

arista.avd.eos_designs

How to test

Tested with the faulty repo (cannot test failures in molecule)

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested a review from a team as a code owner March 30, 2023 12:29
@github-actions github-actions bot added the role: eos_designs issue related to eos_designs role label Mar 30, 2023
@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Mar 30, 2023
@gmuloc gmuloc added this to the v4.0.0-dev9 milestone Mar 30, 2023
@ClausHolbechArista ClausHolbechArista requested a review from a team March 30, 2023 17:40
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit 9fbccf5 into aristanetworks:devel Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Fix(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants