Fix(eos_designs)!: Prevent configuration of IP routing on l2leaf #2684
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Prevent configuration of IP routing on l2leaf
Related Issue(s)
Fixes #1988
Component(s) name
arista.avd.eos_designs
Proposed changes
IP and IPv6 routing is no longer configured on pure L2 devices
For node types like
l2leaf
whereunderlay_router
is set tofalse
undernode_type_keys
AVD versions below 4.0.0still rendered
ip routing
,ip routing ipv6 interfaces
and/oripv6 unicast-routing
in the configuration.As of AVD version 4.0.0 these IP and IPv6 routing configurations are no longer configured for
l2leaf
or other node types with
underlay_router: false
.To retain the old behavior the inventory can be updated like this:
How to test
Most molecule scenarios remove the config, but I have added a unit test combined with rfc5549 and also set
always_configure_ip_routing
on the spines in theeos_designs-l2ls
scenario to test with ipv4 (IMO not worth another host in unit tests).Checklist
User Checklist
Repository Checklist