Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(eos_designs)!: Prevent configuration of IP routing on l2leaf #2684

Conversation

ClausHolbechArista
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista commented Apr 1, 2023

Change Summary

Prevent configuration of IP routing on l2leaf

Related Issue(s)

Fixes #1988

Component(s) name

arista.avd.eos_designs

Proposed changes

IP and IPv6 routing is no longer configured on pure L2 devices

For node types like l2leaf where underlay_router is set to false under node_type_keys AVD versions below 4.0.0
still rendered ip routing, ip routing ipv6 interfaces and/or ipv6 unicast-routing in the configuration.
As of AVD version 4.0.0 these IP and IPv6 routing configurations are no longer configured for l2leaf
or other node types with underlay_router: false.

To retain the old behavior the inventory can be updated like this:

l2leaf:
  defaults:
    always_configure_ip_routing: true

How to test

Most molecule scenarios remove the config, but I have added a unit test combined with rfc5549 and also set always_configure_ip_routing on the spines in the eos_designs-l2ls scenario to test with ipv4 (IMO not worth another host in unit tests).

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ClausHolbechArista ClausHolbechArista requested a review from a team as a code owner April 1, 2023 17:34
@ClausHolbechArista ClausHolbechArista changed the title Fix(eos_designs)!: Prevent configuration of ip routing on l2leaf Fix(eos_designs)!: Prevent configuration of IP routing on l2leaf Apr 1, 2023
@github-actions github-actions bot added role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: documentation Improvements or additions to documentation labels Apr 1, 2023
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmuloc gmuloc merged commit 112517f into aristanetworks:devel Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Fix(eos_designs)! role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IP routing and multi-agent enabled on l2 switches
3 participants