Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(eos_designs): Invalid defaults for ipvpn_gateway domain IDs #2739

Merged
merged 3 commits into from
Apr 18, 2023
Merged

Fix(eos_designs): Invalid defaults for ipvpn_gateway domain IDs #2739

merged 3 commits into from
Apr 18, 2023

Conversation

emilarista
Copy link
Contributor

Change Summary

Fixes invalid defaults for ipvpn_gateway domain IDs, replaces with verified working defaults.

Related Issue(s)

Fixes #2693

Component(s) name

arista.avd.eos_designs

Proposed changes

Old defaults:

< node_type_key >:
    ipvpn_gateway:
        # Domain IDs are required to perform D-Path lookups for loop prevention. If omitted, the defaults are used.
        evpn_domain_id: < "nn:nn" | default -> "0:1" >
        ipvpn_domain_id: < "nn:nn" | default -> "0:2" >

New defaults:

< node_type_key >:
    ipvpn_gateway:
        # Domain IDs are required to perform D-Path lookups for loop prevention. If omitted, the defaults are used.
        evpn_domain_id: < "nn:nn" | default -> "65535:1" >
        ipvpn_domain_id: < "nn:nn" | default -> "65535:2" >

How to test

Tested on hardware device to confirm new defaults are valid EOS config.

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Apr 18, 2023
@emilarista emilarista marked this pull request as ready for review April 18, 2023 09:47
@emilarista emilarista requested a review from a team as a code owner April 18, 2023 09:47
carlbuchmann
carlbuchmann approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you @emilarista for addressing this!

@carlbuchmann carlbuchmann merged commit d02da09 into aristanetworks:devel Apr 18, 2023
@carlbuchmann carlbuchmann added the cherry-pick-for-3.8.x PR to be cherry-picked to releases/v3.8.x brach later label Apr 18, 2023
carlbuchmann pushed a commit to carlbuchmann/avd that referenced this pull request May 12, 2023
@emilarista @carlbuchmann
Fix(eos_designs): Invalid defaults for ipvpn_gateway domain IDs (aris…
ad4ef60 
…tanetworks#2739)
@carlbuchmann carlbuchmann mentioned this pull request May 12, 2023
Merged
@carlbuchmann carlbuchmann removed the cherry-pick-for-3.8.x PR to be cherry-picked to releases/v3.8.x brach later label May 12, 2023
gmuloc pushed a commit that referenced this pull request May 12, 2023
@carlbuchmann @emilarista
Fix(eos_designs): Invalid defaults for ipvpn_gateway domain IDs (#2739)…
ced2d09 
… (#2820)

Co-authored-by: emilarista <73955263+emilarista@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlbuchmann carlbuchmann carlbuchmann approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

Assignees

@emilarista emilarista

Labels
rn: Fix(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid eos_designs defaults for ipvpn_gateway domain IDs
3 participants
@emilarista @carlbuchmann @ClausHolbechArista