Fix(eos_cli_config_gen): Fix typo in router-bgp.j2

[adietrich-ussignal]

Change Summary

Fixes a typo in the router-bgp.j2 template of eos_cli_config_gen to resolve issues when bfd is set to False under the neighbor configuration.

Related Issue(s)

Fixes #2752

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Revise {{ neighbo.ip_address }} to {{ neighbor.ip_address }}

How to test

Added both BFD True and False use cases to test tenant configurations in the 'evpn_underlay_ebgp_overlay_ebgp' molecule within the bgp_peers configuration section.

Checklist

User Checklist

• N/A

Repository Checklist

• My code has been rebased from devel before I start
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation and documentation have been updated accordingly.
• I have updated molecule CI testing accordingly. (check the box if not applicable)

[gmuloc]

Thanks a lot @adietrich-ussignal for catching this and submitting a PR to fix it!

Could you please add the test for bfd: false in the eos_designs_unit_test scenario - if you have a look in TenantA, bfd: true is being tested already: https://github.com/aristanetworks/ansible-avd/blob/devel/ansible_collections/arista/avd/molecule/eos_designs_unit_tests/inventory/group_vars/DC1_TENANTS_NETWORKS/Tenant_A.yml#L179

Thanks in advance!

[gmuloc]

@carlbuchmann - we will need to cherry-pick this for 3.8.x

[adietrich-ussignal]

@gmuloc I've added the additional test as requested.

[gmuloc]

@gmuloc I've added the additional test as requested.

Thanks @adietrich-ussignal - my apologies for not being more clear in my comment - my intention was to move the test to eos_designs_unit_tests and remove it from the other scenario. Let me know if you want to remove it or I can take care of it.

thanks!

[adietrich-ussignal]

@gmuloc I believe I cleaned the right tests up this time. Thanks for the clarification!

[gmuloc]

LGTM - thanks for the contribution

[carlbuchmann]

@adietrich-ussignal - while reviewing with @gmuloc we noticed another behavior at the cli that required fixing:

• no neighbor {{ neighbor.ip_address }} bfd should only be generated when that device is also defined in a peer_group. This was verified at the CLI with EOS version 4.29.3M.
• This needed fixing in both the vrf and within the default context.

We also moved all testing to eos_cli_config_gen unit tests.

[carlbuchmann]

LGTM