Fix(eos_designs): Fix wrong error message for duplicates network_ports #2756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
role: eos_designs
carlbuchmann
approved these changes
Apr 25, 2023
jonxstill
approved these changes
Apr 25, 2023
Shivani-chourasiya
pushed a commit
to Vibhu-gslab/avd
that referenced
this pull request
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
The error message generation code for duplicate network_ports in PR #2627 is wrong and leads to unhelpful error message
Related Issue(s)
Discovered thanks to #2745 troubleshooting
Component(s) name
arista.avd.eos_designsProposed changes
Change the format of the error message
How to test
Added a molecule negative unit test (will need to be revisited with #2748
Checklist
Repository Checklist