Refactor(eos_designs): Move default variables to python instead of role defaults. #2760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
role: eos_designs
ClausHolbechArista
force-pushed
the
refactor/eos_designs/Move-default-variables-to-python
branch
from
4c6a959
to
892975f
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
ClausHolbechArista
force-pushed
the
refactor/eos_designs/Move-default-variables-to-python
branch
from
e984993
to
d951589
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
ClausHolbechArista
force-pushed
the
refactor/eos_designs/Move-default-variables-to-python
branch
from
f4876be
to
525c35e
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
ClausHolbechArista
force-pushed
the
refactor/eos_designs/Move-default-variables-to-python
branch
from
525c35e
to
326fbaa
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
github-actions
bot
added
the
state: CI Updated
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Move default variables to python instead of role defaults
Related Issue(s)
When reusing AVD code outside of Ansible (pyavd) the default values are lost.
Component(s) name
arista.avd.eos_designsProposed changes
yaml_templates_to_factsto load defaultnode_type_keysetc. since those are required for validating input vars according to schema usingdynamic_keys.Note: Still missing
default_templateswhich involves other considerations and will be handled separately.How to test
No change to molecule.
Checklist
User Checklist
Repository Checklist