Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor(eos_cli_config_gen): Deprecate uppercase MIB_family_name in favor of mib_family_name #2772

Merged
merged 5 commits into from
May 3, 2023
Merged

Refactor(eos_cli_config_gen): Deprecate uppercase MIB_family_name in favor of mib_family_name #2772

merged 5 commits into from
May 3, 2023

Conversation

ClausHolbechArista
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista commented May 1, 2023 •
edited by carlbuchmann
Loading

Change Summary

Deprecate uppercase MIB_family_name in favor of mib_family_name

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

  • add new lower case variable in schema
  • fix templates to prefer the new variable but fallback to the old
  • Add deprecation notice on old variable
  • Minor fixes to EOS template to consistent spacing

How to test

  • Changed existing molecule to use the new key
  • Copied the old test to deprecated vars scenario
  • Verified both

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ClausHolbechArista ClausHolbechArista requested a review from a team as a code owner May 1, 2023 08:21
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels May 1, 2023
@ClausHolbechArista ClausHolbechArista mentioned this pull request May 1, 2023
Open
@ClausHolbechArista ClausHolbechArista changed the title Refactor(eos_cli_config_gen): Deperecate uppercase MIB_family_name in favor of mib_family_name Refactor(eos_cli_config_gen): Deprecate uppercase MIB_family_name in favor of mib_family_name May 1, 2023
@carlbuchmann carlbuchmann added this to the v4.0.0-dev12 milestone May 1, 2023
carlbuchmann and others added 3 commits May 2, 2023 12:00
@carlbuchmann
Merge branch 'devel' into refactor/eos_cli_config_gen/deprecate-upper…
06ed328 
…case-MIB_family_name-in-favor-of-mib_family_name
@ClausHolbechArista
Merge branch 'devel' into refactor/eos_cli_config_gen/deprecate-upper…
0347836 
…case-MIB_family_name-in-favor-of-mib_family_name
@ClausHolbechArista
Merge branch 'devel' into refactor/eos_cli_config_gen/deprecate-upper…
bedc6ff 
…case-MIB_family_name-in-favor-of-mib_family_name
carlbuchmann
carlbuchmann approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmuloc gmuloc merged commit ba43d58 into aristanetworks:devel May 3, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc approved these changes

@carlbuchmann carlbuchmann carlbuchmann approved these changes

Assignees

@ClausHolbechArista ClausHolbechArista

Labels
rn: Refactor(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
v4.0.0-dev12
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ClausHolbechArista @gmuloc @carlbuchmann