Feat(eos_designs): Sflow configuration at fabric level #2775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into sflow_eos_designs
github-actions
bot
added
role: eos_designs
xaviramon
changed the title
ClausHolbechArista
requested changes
May 2, 2023
ansible_collections/arista/avd/roles/eos_designs/doc/fabric-variables-v4.0.md
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/plugins/plugin_utils/eos_designs_shared_utils/misc.py
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_designs/schemas/schema_fragments/fabric_sflow.yml
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_designs/schemas/schema_fragments/fabric_sflow.yml
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_designs/schemas/schema_fragments/fabric_sflow.yml
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_designs/schemas/schema_fragments/fabric_sflow.yml
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_designs/schemas/schema_fragments/fabric_sflow.yml
Outdated
Show resolved
Hide resolved
..._collections/arista/avd/roles/eos_designs/schemas/schema_fragments/defs_p2p_links.schema.yml
Outdated
Show resolved
Hide resolved
...ections/arista/avd/roles/eos_designs/schemas/schema_fragments/defs_adapter_config.schema.yml
Outdated
Show resolved
Hide resolved
...ections/arista/avd/roles/eos_designs/schemas/schema_fragments/defs_adapter_config.schema.yml
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/plugins/plugin_utils/eos_designs_shared_utils/misc.py
Outdated
Show resolved
Hide resolved
…a_fragments/fabric_sflow.yml Co-authored-by: Claus Holbech <holbech@arista.com>
…into sflow_eos_designs
ansible_collections/arista/avd/roles/eos_designs/python_modules/underlay/utils.py
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_designs/python_modules/underlay/utils.py
Outdated
Show resolved
Hide resolved
...tions/arista/avd/roles/eos_designs/python_modules/connected_endpoints/ethernet_interfaces.py
Outdated
Show resolved
Hide resolved
...s/arista/avd/roles/eos_designs/python_modules/connected_endpoints/port_channel_interfaces.py
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_designs/python_modules/core_interfaces/utils.py
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_designs/python_modules/l3_edge/utils.py
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_designs/schemas/schema_fragments/fabric_sflow.yml
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_designs/schemas/schema_fragments/fabric_sflow.yml
Outdated
Show resolved
Hide resolved
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…into sflow_eos_designs
xaviramon
force-pushed
the
sflow_eos_designs
branch
from
52a8edf
to
4fdcb1d
Compare
...tions/arista/avd/roles/eos_designs/python_modules/connected_endpoints/ethernet_interfaces.py
Outdated
Show resolved
Hide resolved
...tions/arista/avd/roles/eos_designs/python_modules/connected_endpoints/ethernet_interfaces.py
Outdated
Show resolved
Hide resolved
| @@ -32,6 +32,7 @@ def ethernet_interfaces(self) -> list | None: | |||
| "description": self.shared_utils.interface_descriptions.underlay_ethernet_interfaces(link["type"], link["peer"], link["peer_interface"]), | |||
| "speed": link.get("speed"), | |||
| "shutdown": self.shared_utils.shutdown_interfaces_towards_undeployed_peers and not link["peer_is_deployed"], | |||
| "sflow": link.get("sflow"), | |||
There was a problem hiding this comment.
This should be moved to the update below, so insert after line 47.
..._collections/arista/avd/molecule/eos_designs_unit_tests/inventory/group_vars/SFLOW_TESTS.yml
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_designs_unit_tests/inventory/hosts.yml
Show resolved
Hide resolved
ClausHolbechArista
approved these changes
Jul 7, 2023
gmuloc
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
This PR puts in place all necessary logic to implement sflow in the fabric at all integration points: uplinks, downlinks, enpoints, l3edge and core-interfaces.
Related Issue(s)
Fixes #2311
Component(s) name
arista.avd.eos_designsProposed changes
This is the proposed data model:
This interacts with the existing eos_cli_config_gen module to understand if the
interface disable defaultis set or not in order to configure the ports properlyHow to test
Molecule test included
Checklist
User Checklist
Repository Checklist