Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Add support for "ip_igmp_version" under "vlan_interfaces" #2792

Merged
merged 2 commits into from
May 4, 2023
Merged

Feat(eos_cli_config_gen): Add support for "ip_igmp_version" under "vlan_interfaces" #2792

merged 2 commits into from
May 4, 2023

Conversation

ClausHolbechArista
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista commented May 4, 2023 •
edited
Loading

Change Summary

Add support for "ip_igmp_version" under "vlan_interfaces"

Related Issue(s)

Part of #2790

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Add ip_igmp_version under vlan_interfaces.

        ip_igmp_version:
          type: int
          convert_types:
            - str
          min: 1
          max: 3

How to test

Added molecule

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ClausHolbechArista ClausHolbechArista requested a review from a team as a code owner May 4, 2023 11:56
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels May 4, 2023
@ClausHolbechArista ClausHolbechArista force-pushed the feat/eos_cli_config_gen/ip_igmp_version branch from 3f09e4a to 17704b9 Compare May 4, 2023 12:00
@ClausHolbechArista ClausHolbechArista added this to the v4.0.0-dev12 milestone May 4, 2023
carlbuchmann
carlbuchmann approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann requested a review from a team May 4, 2023 19:16
JulioPDX
JulioPDX approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@JulioPDX JulioPDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JulioPDX JulioPDX merged commit 7519545 into aristanetworks:devel May 4, 2023
35 checks passed
@ClausHolbechArista ClausHolbechArista mentioned this pull request May 8, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlbuchmann carlbuchmann carlbuchmann approved these changes

@JulioPDX JulioPDX JulioPDX approved these changes

Assignees

@ClausHolbechArista ClausHolbechArista

Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
v4.0.0-dev12
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ClausHolbechArista @carlbuchmann @JulioPDX