Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Add priority flow control to qos profile #2796

Merged
merged 22 commits into from
Aug 11, 2023
Merged

Feat(eos_cli_config_gen): Add priority flow control to qos profile #2796

merged 22 commits into from
Aug 11, 2023

Conversation

chetryan
Copy link
Contributor

@chetryan chetryan commented May 4, 2023 •
edited
Loading

Change Summary

Add functionality to set Priority Flow Control in QoS Profiles and global settings.
Without this Pull Request, priority flow control can only be set on ethernet ports using the eos_cli_config_gen schema.

Related Issue(s)

No existing issues.

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

  • Add a new schema for PFC configuration within a qos profile
  • Add a new schema for Global PFC configuration
  • Update template for qos-profile generation to add new pfc knobs
  • Add new template for global PFC configuration

How to test

  • run molecule test -s eos_cli_conifg_gen

Checklist

User Checklist

  • provide feedback on Documentation generation. Does it look good? Is it what we expect form AVD.
  • Review the jinja templates to ensure adherence to AVD standards

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels May 4, 2023
@chetryan chetryan changed the title Add priority flow control to qos profile Feat(eos_cli_config_gen): Add priority flow control to qos profile May 4, 2023
@chetryan chetryan marked this pull request as ready for review May 9, 2023 08:17
@chetryan chetryan requested a review from a team as a code owner May 9, 2023 08:17
ClausHolbechArista
ClausHolbechArista previously approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final minor adjustment to descriptions. Other than that LGTM.

...rista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/priority_flow_control.schema.yml Outdated Show resolved Hide resolved
...rista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/priority_flow_control.schema.yml Outdated Show resolved Hide resolved
...rista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/priority_flow_control.schema.yml Outdated Show resolved Hide resolved
...ections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/qos_profiles.schema.yml Outdated Show resolved Hide resolved
...ections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/qos_profiles.schema.yml Outdated Show resolved Hide resolved
...ections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/qos_profiles.schema.yml Outdated Show resolved Hide resolved
@ClausHolbechArista ClausHolbechArista requested a review from a team May 10, 2023 17:15
@github-actions github-actions bot added the state: conflict PR with conflict label May 19, 2023
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label May 22, 2023
@github-actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@carlbuchmann carlbuchmann added this to the v4.1.0 milestone May 30, 2023
@github-actions github-actions bot added the state: conflict PR with conflict label Jun 13, 2023
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@chetryan chetryan requested a review from a team as a code owner June 16, 2023 12:33
@github-actions github-actions bot removed the state: conflict PR with conflict label Jun 16, 2023
@github-actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@ClausHolbechArista ClausHolbechArista dismissed their stale review June 16, 2023 13:45

caught some new things

@ClausHolbechArista ClausHolbechArista requested a review from a team July 3, 2023 07:01
chetryan and others added 18 commits August 10, 2023 17:21
@chetryan @carlbuchmann
Feat(eos_cli_config_gen): PFC Watchdog
fc53ac3 
Add configuration of Priority Flow Control watchdog in the
qos profile.
@chetryan @carlbuchmann
Fix(eos_cli_config_gen): Remove extra return
dbc6787
@chetryan @ClausHolbechArista @carlbuchmann
Update ansible_collections/arista/avd/roles/eos_cli_config_gen/templa…
9d634e2 
…tes/documentation/qos-profiles.j2

Co-authored-by: Claus Holbech <holbech@arista.com>
@chetryan @carlbuchmann
Fix(eos_cli_config_gen): Resolve PR feedback
a2208c2 
Fix Documentation generation.
Improve logic in config generation template.
@chetryan @carlbuchmann
Feat: Add global pfc
8d9dc86
@chetryan @carlbuchmann
Feat(eos_config_cli_gen): Global PFC config
2db073e
@chetryan @ClausHolbechArista @carlbuchmann
Update ansible_collections/arista/avd/roles/eos_cli_config_gen/schema…
9719c55 
…s/schema_fragments/priority_flow_control.schema.yml

Co-authored-by: Claus Holbech <holbech@arista.com>
@chetryan @ClausHolbechArista @carlbuchmann
Update ansible_collections/arista/avd/roles/eos_cli_config_gen/schema…
d55bb4c 
…s/schema_fragments/qos_profiles.schema.yml

Co-authored-by: Claus Holbech <holbech@arista.com>
@chetryan @ClausHolbechArista @carlbuchmann
Apply suggestions from code review
001e3e2 
Add conversation for float

Co-authored-by: Claus Holbech <holbech@arista.com>
@chetryan @carlbuchmann
Fix: Update the schema
30f350e
@chetryan @ClausHolbechArista @carlbuchmann
Update ansible_collections/arista/avd/roles/eos_cli_config_gen/schema…
a56866d 
…s/schema_fragments/qos_profiles.schema.yml

Co-authored-by: Claus Holbech <holbech@arista.com>
@chetryan @ClausHolbechArista @carlbuchmann
Apply suggestions from code review
f1e8c28 
Co-authored-by: Claus Holbech <holbech@arista.com>
@chetryan @carlbuchmann
Update schema and molecule test
64ffd16
@chetryan @carlbuchmann
Fix(eos_cli_config_gen): Update desc in schema
1caf9bd
@chetryan @ClausHolbechArista @carlbuchmann
Apply suggestions from code review
09ccade 
Co-authored-by: Claus Holbech <holbech@arista.com>
@chetryan @carlbuchmann
Fix(eos_cli_config_gen): Regenerate Schema
692bfd1
@chetryan @carlbuchmann
Fix: Update schema with correct decimal precision
472bf68
@chetryan @carlbuchmann
FIX(eos_cli_config_gen): Add regex line start/end
e1cc488
@github-actions github-actions bot removed the role: eos_designs issue related to eos_designs role label Aug 10, 2023
@carlbuchmann carlbuchmann self-requested a review August 11, 2023 13:25
carlbuchmann
carlbuchmann approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit 4bfa22a into aristanetworks:devel Aug 11, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@tgodaA tgodaA tgodaA left review comments

@carlbuchmann carlbuchmann carlbuchmann approved these changes

Assignees

@chetryan chetryan

Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
v4.4.0-dev1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chetryan @carlbuchmann @ClausHolbechArista @tgodaA