New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor(eos_cli_config_gen, eos_designs): Improve BGP VRF Address Families Model #2808
Merged
carlbuchmann
merged 10 commits into
aristanetworks:devel
from
emilarista:bgp_vrf_af_refactor
May 19, 2023
Merged
Refactor(eos_cli_config_gen, eos_designs): Improve BGP VRF Address Families Model #2808
carlbuchmann
merged 10 commits into
aristanetworks:devel
from
emilarista:bgp_vrf_af_refactor
May 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
role: eos_designs
issue related to eos_designs role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
labels
May 10, 2023
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/router-bgp.j2
Show resolved
Hide resolved
...llections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_bgp.schema.yml
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/router-bgp.j2
Outdated
Show resolved
Hide resolved
github-actions
bot
added
the
type: documentation
Improvements or additions to documentation
label
May 12, 2023
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
ClausHolbechArista
approved these changes
May 16, 2023
ClausHolbechArista
approved these changes
May 16, 2023
Co-authored-by: Claus Holbech <holbech@arista.com>
ClausHolbechArista
approved these changes
May 19, 2023
carlbuchmann
approved these changes
May 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
rn: Refactor(eos_cli_config_gen|eos_designs)
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
role: eos_designs
issue related to eos_designs role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
type: documentation
Improvements or additions to documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Related Issue(s)
Fixes #1323
Component(s) name
arista.avd.eos_cli_config_gen
arista.avd.eos_designs
Proposed changes
How to test
Tested with molecule to make sure identical config is rendered.
Repository Checklist