Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_designs): Support for underlay_multicast RPs and Anycast-RP #2846

Merged
merged 4 commits into from Jun 16, 2023
Merged

Feat(eos_designs): Support for underlay_multicast RPs and Anycast-RP #2846

merged 4 commits into from Jun 16, 2023

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Support for underlay_multicast RPs and Anycast-RP

Related Issue(s)

Fixes #1873

Component(s) name

arista.avd.eos_designs

Proposed changes

underlay_multicast_rps:
  - rp: <str>
    nodes:
      - name: <str>
        loopback_number: <int>
        description: <str>
    groups:
      - <str>
    access_list_name: <str>

underlay_multicast_anycast_rp:
  mode: <str>

How to test

Added molecule coverage for all combinations.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ClausHolbechArista ClausHolbechArista requested a review from a team as a code owner May 16, 2023 16:05
@github-actions github-actions bot added role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels May 16, 2023
@ClausHolbechArista ClausHolbechArista added this to the v4.1.0 milestone May 16, 2023
@ClausHolbechArista ClausHolbechArista force-pushed the feat/eos_designs/underlay-multicast-sparse-mode branch from 5303620 to 2540f5a Compare May 16, 2023 17:37
@github-actions github-actions bot added the state: conflict PR with conflict label May 19, 2023
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@perimore perimore mentioned this pull request May 22, 2023
Closed
1 task
@ClausHolbechArista ClausHolbechArista force-pushed the feat/eos_designs/underlay-multicast-sparse-mode branch from 2540f5a to f32abad Compare June 14, 2023 11:46
@github-actions github-actions bot removed the state: conflict PR with conflict label Jun 14, 2023
@github-actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

carlbuchmann
carlbuchmann approved these changes Jun 16, 2023
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista requested a review from a team as a code owner June 16, 2023 14:37
@ClausHolbechArista ClausHolbechArista merged commit dcbfe66 into aristanetworks:devel Jun 16, 2023
31 checks passed
@jonxstill jonxstill mentioned this pull request Oct 4, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlbuchmann carlbuchmann carlbuchmann approved these changes

Assignees

@ClausHolbechArista ClausHolbechArista

Labels
rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
v4.1.0
Development

Successfully merging this pull request may close these issues.

Support for underlay multicast in eos_designs
2 participants
@ClausHolbechArista @carlbuchmann