Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_designs)!: Platform and Fabric variables to adjust update wait-for-convergence and update wait-install #2855

Merged
merged 5 commits into from
May 19, 2023
Merged

Feat(eos_designs)!: Platform and Fabric variables to adjust update wait-for-convergence and update wait-install #2855

merged 5 commits into from
May 19, 2023

Conversation

carlbuchmann
Copy link
Member

@carlbuchmann carlbuchmann commented May 18, 2023 •
edited by ClausHolbechArista
Loading

Change Summary

Platform and Fabric variables to adjust update wait-for-convergence and update wait-install

Related Issue(s)

Fixes #2839

Component(s) name

arista.avd.eos_designs

Proposed changes

Create new following keys:

bgp_update wait_for_convergence: <bool> -> default unset 
bgp_update_wait_install: <bool> -> default true 

platform_settings:
      - platforms: "for all hardware based platforms"
        feature_support:
            bgp_update_wait_for_convergence: <bool> -> default true
            bgp_update_wait_install: <bool> -> default true
      - platforms: "veos & ceos"
        feature_support:
            bgp_update_wait_for_convergence: false 
            bgp_update_wait_install: false

added test in eos_designs_untis_tests

  • DC1-LEAF1A
  • DC1-LEAF2A
  • DC1-LEAF2B

How to test

See molecule scenarios

Checklist

  • update schema
  • implement code
  • update release notes and porting guide

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: documentation Improvements or additions to documentation state: conflict PR with conflict labels May 18, 2023
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@carlbuchmann carlbuchmann added this to the v4.0.0-rc1 milestone May 18, 2023
@carlbuchmann carlbuchmann changed the title Feat(eos_designs)!: Support bgp update wait-for-convergence and update wait-install Feat(eos_designs)!: Platform and Fabric variables to adjust update wait-for-convergence and update wait-install May 18, 2023
@github-actions github-actions bot removed the state: conflict PR with conflict label May 19, 2023
@github-actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

ClausHolbechArista
ClausHolbechArista requested changes May 19, 2023
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Add porting guide and release notes

@carlbuchmann carlbuchmann marked this pull request as ready for review May 19, 2023 17:38
@carlbuchmann carlbuchmann requested a review from a team as a code owner May 19, 2023 17:38
@github-actions github-actions bot added the state: conflict PR with conflict label May 19, 2023
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label May 19, 2023
@github-actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@ClausHolbechArista ClausHolbechArista merged commit 832911d into aristanetworks:devel May 19, 2023
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@onurgashi onurgashi Awaiting requested review from onurgashi

Assignees

@carlbuchmann carlbuchmann

Labels
rn: Feat(eos_designs)! role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: documentation Improvements or additions to documentation
Projects
None yet
Milestone
v4.0.0-rc1
Development

Successfully merging this pull request may close these issues.

Feat(eos_designs): Platform and Fabric variables to adjust update wait-for-convergence and update wait-install
2 participants
@carlbuchmann @ClausHolbechArista